Support pattern variables declared under "is not"#44513
Merged
gafter merged 2 commits intodotnet:masterfrom Jun 12, 2020
Merged
Support pattern variables declared under "is not"#44513gafter merged 2 commits intodotnet:masterfrom
gafter merged 2 commits intodotnet:masterfrom
Conversation
jcouv
reviewed
May 26, 2020
jcouv
reviewed
May 26, 2020
jcouv
reviewed
May 26, 2020
Member
Author
|
@jcouv I think I've responded to your comments. Do you have any others? @dotnet/roslyn-compiler May I please have a second review? |
jcouv
reviewed
May 27, 2020
Member
Author
|
@dotnet/roslyn-compiler May I please have a second review? |
…-isnot-pattern
Member
Author
|
@dotnet/roslyn-compiler May I please have a second review? |
Member
Author
|
@dotnet/roslyn-compiler May I please have a second review of this complete implementation of one of the C# 9.0 features? Would love to get it into the upcoming preview. |
Member
Author
|
@dotnet/roslyn-compiler May I please have a second review? |
cston
approved these changes
Jun 11, 2020
gafter
pushed a commit
to gafter/roslyn
that referenced
this pull request
Jun 12, 2020
ghost
pushed a commit
that referenced
this pull request
Jun 12, 2020
Support pattern variables declared under "is not" (#44513)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements dotnet/csharplang#3369
LDM notes: https://github.com/dotnet/csharplang/blob/master/meetings/2020/LDM-2020-05-06.md#discussion