Ensure that TodoCommentOptions are serialized to OOP#44873
Merged
mavasani merged 1 commit intodotnet:masterfrom Jun 5, 2020
Merged
Ensure that TodoCommentOptions are serialized to OOP#44873mavasani merged 1 commit intodotnet:masterfrom
mavasani merged 1 commit intodotnet:masterfrom
Conversation
Fixes dotnet#43788 TodoCommentOptions and TodoCommentOptionsProvider were defined in EditorFeatures layer and we only serialize the options defined in Workspaces and Features layer to the OOP side: https://github.com/dotnet/roslyn/blob/287a25a51324f252e61b6f2186e7df60c8a6161b/src/Workspaces/Core/Portable/Options/GlobalOptionService.cs#L79-L85 In future, we either need to add support to serialize all changed options to OOP (could be expensive) or somehow enforce that all the OOP related options are defined in Workspaces and Features layer.
Contributor
|
Were you able to validate if this fixes things? |
Contributor
Author
|
@CyrusNajmabadi Yes, the repro in the issue is fixed with this change. |
CyrusNajmabadi
approved these changes
Jun 5, 2020
This was referenced Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43788
TodoCommentOptions and TodoCommentOptionsProvider were defined in EditorFeatures layer and we only serialize the options defined in Workspaces and Features layer to the OOP side:
roslyn/src/Workspaces/Core/Portable/Options/GlobalOptionService.cs
Lines 79 to 85 in 287a25a
In future, we either need to add support to serialize all changed options to OOP (could be expensive) or somehow enforce that all the OOP related options are defined in Workspaces and Features layer.