Merged
Conversation
…ecidim into feature/redesign-verifications
5c8116a to
535d66b
Compare
Contributor
Author
|
ping @ahukkanen @decidim/product |
carolromero
previously requested changes
Nov 8, 2022
Member
There was a problem hiding this comment.
Overall, everything we were able to test works well. We have not been able to test these views though:
- choose Id document: https://decidim-redesign.populate.tools/id_documents/authorizations/choose
- new sms: https://decidim-redesign.populate.tools/sms/authorizations/new
- edit sms: https://decidim-redesign.populate.tools/sms/authorizations/edit
Is there any chance to configure SMS or have a way to review it?
List
- We are still unclear about the use of icons to indicate different information: the type of verification and the status of the verification. So we ask to choose a single use (personally I don't find so important to have a differentiated icon for the type of verification, but we leave it up to you @rober-gd).
Contributor
|
Just a note here is that still the verification feature looks fine for me but I will wait until #9858 is merged because there are some merge conflicts between these two PRs. I also think that the file upload feature should work first before we merge this one. |
Contributor
|
@Crashillo I just merged #9858 which caused a few merge conflicts with this one. Could you resolve those please? 🙏 |
ferblape
reviewed
Nov 24, 2022
decidim-core/app/views/layouts/decidim/redesigned_user_profile.html.erb
Outdated
Show resolved
Hide resolved
ferblape
reviewed
Nov 24, 2022
decidim-verifications/app/views/layouts/decidim/redesigned_authorizations.html.erb
Outdated
Show resolved
Hide resolved
ahukkanen
requested changes
Nov 25, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
One more a11y issue I noticed and also left few other comments below.
Please check the a11y toolbar always to check that there are no technical violations on the redesigned pages.
...dim-verifications/app/views/decidim/verifications/id_documents/authorizations/_form.html.erb
Show resolved
Hide resolved
...dim-verifications/app/views/decidim/verifications/id_documents/authorizations/_form.html.erb
Show resolved
Hide resolved
This was referenced Nov 25, 2022
ahukkanen
approved these changes
Nov 28, 2022
4 tasks
entantoencuanto
added a commit
that referenced
this pull request
Nov 28, 2022
* develop: Redesign: verifications (#9759) Fix machine translations at the API (#9652) Add title and description to the attachment API type (#10114) Correct the "voted for this" string in the budgets component (#10113) Fix filter URL not updated with the text search input (#9618) Improve README design and contents (#10065) Update bulletin board to 0.24 for Ruby 3.1 compatibility (#9766) Fix some oversights in the release notes for the next release (#10078) Fix bug regarding user group moderation action logs (#10085) Fix wrong capitalization in i18n values and add missing keys (#10072) Enhance templates engine (#10015) Add slash in PR linter configuration (#10074) Allow blocking a UserGroup (#10021) Enable newsletters for admin on seeds (#10073)
entantoencuanto
added a commit
that referenced
this pull request
Nov 28, 2022
* develop: Redesign: verifications (#9759) Fix machine translations at the API (#9652) Add title and description to the attachment API type (#10114) Correct the "voted for this" string in the budgets component (#10113) Fix filter URL not updated with the text search input (#9618) Improve README design and contents (#10065)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Redesign verifications
📷 Screenshots
(user: decidim / pwd: staging123)