Fix doorkeeper initialization after 5.6.0 release#9785
Merged
andreslucena merged 1 commit intodecidim:developfrom Sep 12, 2022
Merged
Fix doorkeeper initialization after 5.6.0 release#9785andreslucena merged 1 commit intodecidim:developfrom
andreslucena merged 1 commit intodecidim:developfrom
Conversation
Contributor
Author
|
The generators spec is failing when it's running the generator with the Once this is merged, the build should be green. |
andreslucena
approved these changes
Sep 12, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
I've tried it locally, and it works as expected. 👍🏽
entantoencuanto
added a commit
that referenced
this pull request
Sep 12, 2022
* develop: Fix doorkeeper initialization after 5.6.0 release (#9785)
This was referenced Sep 12, 2022
entantoencuanto
added a commit
that referenced
this pull request
Sep 12, 2022
* develop: Fix doorkeeper initialization after 5.6.0 release (#9785)
fblupi
pushed a commit
to AjuntamentdeBarcelona/decidim
that referenced
this pull request
Sep 19, 2022
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
laurajaime
pushed a commit
to CodiTramuntana/decidim
that referenced
this pull request
Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Yesterday Doorkeeper released version 5.6.0 and Decidim generators will automatically start using that due to the loose version lock to Doorkeeper
5.x.It included this change:
doorkeeper-gem/doorkeeper@e19466f
This causes Doorkeeper to check if it has been configured already during the initialization hook. Which then causes the exception because Doorkeeper configuration in Decidim runs after the Doorkeeper initialization has run.
This causes the generators tests to fail constantly in the CI to the following exception:
Testing
See that the generators tests are green.