Conversation
490fb39 to
aca477f
Compare
aca477f to
26a3ac5
Compare
Base automatically changed from
feature/redesign-main-layout
to
feature/redesign
June 29, 2022 13:17
30b2ce4 to
6a3d923
Compare
efb2a79 to
29040bb
Compare
aac3bd8 to
ceab92e
Compare
|
Things to review: No topic
Topic
List
Space Page
|
ceab92e to
4db4e8a
Compare
d58e383 to
8550025
Compare
|
Only three things to fix (sorry for not seeing it in the previous review) List
No topic / Participatory space page
|
Contributor
Author
List
topic_links.mp4Topic
|
Contributor
|
@Crashillo Thanks for fixing the conflict. Are you planning to address the latest feedback later on and want to get this merged before it is addressed? Just asking because you requested review on this one already although there are unresolved issues. |
Contributor
Author
|
Hmmm, my bad. Definitely, I saw green tests and re-request review button active and I went straight 😅 I'll solve as much as I can, otherwise I'll addressed in the pending issue. I'll come back to you then. |
Contributor
Author
|
@ahukkanen you may take a look again |
ahukkanen
requested changes
Aug 18, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
I had another look but one of the issues from the previous review was not addressed.
Otherwise it's good with the pending issues moved to #9753.
Could you have another look at the cluttered standalone page view when the user has not yet accepted the TOS?
Contributor
Author
|
I've been working on a layout enhancement that's gonna affect this PR and it's related with the pending point you noticed. Please, review/merge it asap to be able of updating pages accordingly. |
Contributor
|
@Crashillo #9755 is now merged. |
Contributor
Author
|
Tests are green, only codecov is complaining |
Contributor
|
@Crashillo There is still a linting issue with the code. |
Contributor
|
Ready, @ahukkanen |
entantoencuanto
added a commit
that referenced
this pull request
Aug 25, 2022
* develop: Redesign: pages (#9457) Add "no-reply" notification at the email footers (#9668) merge layout center into one-col, allowing 3 variations (#9755) Fix form error overlap with character counter in the admin panel (#9683) Change the custom public port ENV variable name to HTTP_PORT (#9598) Redesign: login & signup (#9455) Fix redundant notification on comments with linked proposals (#9676)
Merged
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
* index pages * no themed page * themed page * fix stylelint * participatory space page * announcement cell * keep foundation status names * tailwind components enhancement * tos pages * Update test * Replace TODO with REDESIGN_PENDING * Recover admin_links in redesigned layout The new styles are pending * Fix rubocop offense * Recover tos refuse modal (redesign pending) * Remove unused translation * Fix selector in test * Fix announcement cell test * Update announcement selector in tests * Set actions affected by redesign in pages controller * Fix accessibility issue * Fix selector in test * Fix heading-order accesibility issue * Fix ARIA roles accesibility issue * Disable layout specific of participatory process (redesign pending) * accordion style & add bypass behaviour * space page * Remove blank line * use a data-attribute instead * test a11y summary * Update css selector in test * tune accordion titles * Fix selector in test * replace details-summary with a11y accordion * fix stylelint * missing resource * fix class names * fix prose * extract styles from tabbed * Fix selector in test * test a11y accordion * test a11y accordion * force display:none to all children * use button as trigger instead * test accordion a11y * fix test * rename component to avoid confusion * hide accordion panel onload * fix headings * fixes responsive layout * Fix spec * update css class for tests * fixes over pages * fix wrong condition * edit gaps & containers based on the new layouts * fix test, & componentize tabs * change css class * add also dialog a11y lib * remove dummy markup * Remove unused function definition Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com> Co-authored-by: Fernando Blat <fernando@blat.es>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Redesign themed and untopic pages. It includes announcement component.
Considerations
New NPM library included
📌 Related Issues
This PR has built on top of #9340
📷 Screenshots