Skip to content

Redesign: Layout#9755

Merged
ahukkanen merged 1 commit intodevelopfrom
feature/redesign-layouts
Aug 18, 2022
Merged

Redesign: Layout#9755
ahukkanen merged 1 commit intodevelopfrom
feature/redesign-layouts

Conversation

@Crashillo
Copy link
Copy Markdown
Contributor

@Crashillo Crashillo commented Aug 18, 2022

🎩 What? Why?

Enhancement layout handler. Combine different centered layouts in order to be chosen by rails partials.

This PR will break some redesigned views, so it's important to be merged asap, hence I can update the rest of open PRs accordingly.

@Crashillo Crashillo requested a review from ahukkanen August 18, 2022 09:56
@Crashillo Crashillo added the project: redesign Barcelona City Council contract label Aug 18, 2022
@Crashillo Crashillo mentioned this pull request Aug 18, 2022
@ahukkanen ahukkanen merged commit aa57ac1 into develop Aug 18, 2022
@ahukkanen ahukkanen deleted the feature/redesign-layouts branch August 18, 2022 10:40
entantoencuanto added a commit that referenced this pull request Aug 25, 2022
* develop:
  Redesign: pages (#9457)
  Add "no-reply" notification at the email footers (#9668)
  merge layout center into one-col, allowing 3 variations (#9755)
  Fix form error overlap with character counter in the admin panel (#9683)
  Change the custom public port ENV variable name to HTTP_PORT (#9598)
  Redesign: login & signup (#9455)
  Fix redundant notification on comments with linked proposals (#9676)
entantoencuanto added a commit that referenced this pull request Sep 12, 2022
…taging

* feature/redesign-verifications:
  replace button with icon, make whole item clickable
  Move datepicker format info to help_text and ovewrite it if defined by options
  fix erblint
  Fix announcement helper method
  Add parentheses
  dummy app & first_login
  sms new/edit
  postal_letter new/edit
  choose view
  add helper (with error) + edit view
  id_documents
  extract login forms to component, apply in verifications
  verifications index
  set icons for each verification method
  create a common layout for user_profile defined in the views, not in the controllers
  merge layout center into one-col, allowing 3 variations (#9755)
  Allow to define an icon on verification workflow manifests
  verification index
  git empty folder
  initial commit to config assets
eliegaboriau pushed a commit to eliegaboriau/decidim that referenced this pull request Oct 25, 2022
ahukkanen pushed a commit that referenced this pull request Nov 28, 2022
* initial commit to config assets

* git empty folder

* verification index

* Allow to define an icon on verification workflow manifests

* merge layout center into one-col, allowing 3 variations (#9755)

* create a common layout for user_profile defined in the views, not in the controllers

* set icons for each verification method

* verifications index

* extract login forms to component, apply in verifications

* id_documents

* add helper (with error) + edit view

* choose view

* postal_letter new/edit

* sms new/edit

* dummy app & first_login

* Add parentheses

* Fix announcement helper method

* fix erblint

* Move datepicker format info to help_text and ovewrite it if defined by options

* replace button with icon, make whole item clickable

* modal required files

* allow remote, jquery-free modals 🎉

* modal verification & a11y stuff

* fix lint & translations

* fix test

* Define visit_authorizations method in test prepared to redesign

* Update sign in interaction to work also with redesign

* Update selector in tests

* Disable test pending of redesign

* Update selector in test

* Disable interaction in tests pending of redesign

* Update test to work with redesign also

* Fix tests

* caret down form select input

* add back button to all pages

* vertical tabs as dropdown for mobile (partial)

* Define method in menu presenter to return active item and use it in dropdown label

* clean renew-modal as of the shared styles

* Refactor verifications subsections and change date format

* Fix modal

* Fix test

* Add missing paths

* Use specific layout in verifications views and extract common code

* Handle dynamic content views for upload modal

* fix stylelint

* Prepare button to open login modal to work with redesigned and legacy layouts

* Split upload modal cell in legacy and redesigned versions and allow to call it passing a redesign option

* add span to button/links

* responsive buttons

* layout content min height

* add back link

* set space to explanation texts

* Remove wrong image_tag for attachment without checking the presence of attachment as image

* good version files.erb

* Fix attachment blob call

* Skip test temporarily pending of merge of another PR

See #9858, this PR depends on it

* glitches responsives

* Fix expected class in test

* remove new dependencies from the old js file. Move them to new one

* add modal selectors ternaries

* fix renew modal responsive styles

* handle different markup in redesign

* add new libraries to legacy scripts

* restore template

* Remove useless assignment

Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: redesign Barcelona City Council contract

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants