Fix form error overlap with character counter in the admin panel#9683
Merged
ahukkanen merged 3 commits intodecidim:developfrom Aug 15, 2022
Merged
Fix form error overlap with character counter in the admin panel#9683ahukkanen merged 3 commits intodecidim:developfrom
ahukkanen merged 3 commits intodecidim:developfrom
Conversation
ahukkanen
requested changes
Aug 12, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
There is one problem with the approach and I also would fix this everywhere, not only for the hashtag containers as in the proposed solution.
Please see the comments below.
decidim-admin/app/packs/stylesheets/decidim/admin/modules/_forms.scss
Outdated
Show resolved
Hide resolved
ahukkanen
approved these changes
Aug 15, 2022
entantoencuanto
added a commit
that referenced
this pull request
Aug 25, 2022
* develop: Redesign: pages (#9457) Add "no-reply" notification at the email footers (#9668) merge layout center into one-col, allowing 3 variations (#9755) Fix form error overlap with character counter in the admin panel (#9683) Change the custom public port ENV variable name to HTTP_PORT (#9598) Redesign: login & signup (#9455) Fix redundant notification on comments with linked proposals (#9676)
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
…idim#9683) * Fix mixin issue in proposal title * Fix reviewer's comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The validation rules of the proposals form are stepped between them in the administration panel.
📌 Related Issues
Testing
No testing is needed for such changes. Visually, it can be testified.
📷 Screenshots
After this fix, the error looks like this:
