Skip to content

Redesign: notifications#9447

Merged
ahukkanen merged 20 commits intodevelopfrom
feature/redesign-notifications
Aug 29, 2022
Merged

Redesign: notifications#9447
ahukkanen merged 20 commits intodevelopfrom
feature/redesign-notifications

Conversation

@Crashillo
Copy link
Copy Markdown
Contributor

@Crashillo Crashillo commented Jun 16, 2022

🎩 What? Why?

Redesign notifications list

📌 Related Issues

This PR has built on top of #9344

📷 Screenshots

https://decidim-redesign.populate.tools/notifications (login first)

♥️ Thank you!

@Crashillo Crashillo changed the base branch from develop to feature/redesign-main-layout June 16, 2022 16:04
@Crashillo Crashillo changed the base branch from feature/redesign-main-layout to feature/redesign-components June 16, 2022 16:05
@Crashillo Crashillo changed the title Feature/redesign notifications Redesign: notifications Jun 16, 2022
@Crashillo Crashillo force-pushed the feature/redesign-notifications branch 3 times, most recently from fef429a to 3e7f7cd Compare June 17, 2022 15:10
@entantoencuanto entantoencuanto force-pushed the feature/redesign-components branch from 81a9cb4 to 6275947 Compare June 17, 2022 19:04
@entantoencuanto entantoencuanto force-pushed the feature/redesign-notifications branch from 3e7f7cd to f616d93 Compare June 17, 2022 19:14
@Crashillo Crashillo force-pushed the feature/redesign-components branch from 6275947 to 7d748f6 Compare June 20, 2022 11:21
@entantoencuanto entantoencuanto force-pushed the feature/redesign-components branch from 7d748f6 to 1e068e4 Compare June 20, 2022 14:38
@entantoencuanto entantoencuanto force-pushed the feature/redesign-notifications branch from ab2519a to b91bd93 Compare June 20, 2022 20:23
@andreslucena andreslucena added project: redesign Barcelona City Council contract and removed contract: lot: px labels Jun 21, 2022
Base automatically changed from feature/redesign-components to feature/redesign-main-layout June 21, 2022 11:44
@entantoencuanto entantoencuanto force-pushed the feature/redesign-notifications branch 2 times, most recently from 9f3bdcc to 0a34ef8 Compare June 27, 2022 16:54
@entantoencuanto entantoencuanto force-pushed the feature/redesign-notifications branch from 0a34ef8 to c08d567 Compare June 28, 2022 21:56
Base automatically changed from feature/redesign-main-layout to feature/redesign June 29, 2022 13:17
@entantoencuanto entantoencuanto force-pushed the feature/redesign-notifications branch 3 times, most recently from e302f5e to 7174454 Compare July 4, 2022 19:49
Base automatically changed from feature/redesign to develop July 7, 2022 14:51
@entantoencuanto entantoencuanto force-pushed the feature/redesign-notifications branch from 7174454 to 2849f2d Compare July 7, 2022 19:10
@entantoencuanto entantoencuanto force-pushed the feature/redesign-notifications branch 2 times, most recently from 6249c7b to cc8cfa2 Compare July 21, 2022 10:11
@entantoencuanto entantoencuanto force-pushed the feature/redesign-notifications branch from cc8cfa2 to 9e8811e Compare July 27, 2022 14:19
@Crashillo Crashillo requested a review from rober-gd August 4, 2022 15:22
@Crashillo Crashillo marked this pull request as ready for review August 4, 2022 15:22
@entantoencuanto entantoencuanto force-pushed the feature/redesign-notifications branch 2 times, most recently from 1d50a28 to 7f25d10 Compare August 25, 2022 16:02
@entantoencuanto entantoencuanto force-pushed the feature/redesign-notifications branch from 7f25d10 to 9d44062 Compare August 25, 2022 16:17
@ferblape ferblape requested a review from ahukkanen August 29, 2022 09:41
@ahukkanen ahukkanen merged commit 9356312 into develop Aug 29, 2022
@ahukkanen ahukkanen deleted the feature/redesign-notifications branch August 29, 2022 14:44
entantoencuanto added a commit that referenced this pull request Aug 29, 2022
entantoencuanto added a commit that referenced this pull request Aug 29, 2022
* develop:
  Redesign: notifications (#9447)
  Redesign: pages (#9457)
  Add "no-reply" notification at the email footers (#9668)
eliegaboriau pushed a commit to eliegaboriau/decidim that referenced this pull request Oct 25, 2022
* notifications view

* fix css class due to new tailwind config

* remove unnecessary file reference

* extract styles notifications

* add missing file

* fix style glitches

* wrap notification elements for responsive

* fix erblint

* fix notification tests

* refactor notification script (no jquery)

* hide partial if no results

* look for notification updated markup

* Fix deprecation warning

* Display participatory space link and title on notifications

* Fix linter offense

* Small refactor of notifications cell

* Remove check from test

After redesign the notification event class human name is not shown

* Hide read all button if there are no notifications

* Show no notifications message depending of presence of associated resources

* Add a no notifications message using javascript if notifications are empty

Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: redesign Barcelona City Council contract

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants