Fix filter URL not updated with the text search input#9618
Merged
andreslucena merged 8 commits intodecidim:developfrom Nov 23, 2022
Merged
Fix filter URL not updated with the text search input#9618andreslucena merged 8 commits intodecidim:developfrom
andreslucena merged 8 commits intodecidim:developfrom
Conversation
Member
|
Let's retake this PR @ahukkanen, can you merge with develop 🙏🏽 ? Thanks |
Contributor
Author
|
Done @andreslucena |
andreslucena
approved these changes
Nov 23, 2022
Member
There was a problem hiding this comment.
I tried it with all the components (except sortitions that doesn't even have seeds and isn't widely used).
I give it a special eye to what @ahukkanen mentioned in our last meeting:
- back/forward on browser
- JavaScript console errors
- budget module
I also checked it out with the "View all XXX" feature, and it works too.
I don't find out any other place where this could break, actually.
The code is 👌🏽, with specs on all the components and also with jest tests.
In summary, LGTM 👏🏽 👏🏽
entantoencuanto
added a commit
that referenced
this pull request
Nov 28, 2022
* develop: Redesign: verifications (#9759) Fix machine translations at the API (#9652) Add title and description to the attachment API type (#10114) Correct the "voted for this" string in the budgets component (#10113) Fix filter URL not updated with the text search input (#9618) Improve README design and contents (#10065) Update bulletin board to 0.24 for Ruby 3.1 compatibility (#9766) Fix some oversights in the release notes for the next release (#10078) Fix bug regarding user group moderation action logs (#10085) Fix wrong capitalization in i18n values and add missing keys (#10072) Enhance templates engine (#10015) Add slash in PR linter configuration (#10074) Allow blocking a UserGroup (#10021) Enable newsletters for admin on seeds (#10073)
entantoencuanto
added a commit
that referenced
this pull request
Nov 28, 2022
* develop: Redesign: verifications (#9759) Fix machine translations at the API (#9652) Add title and description to the attachment API type (#10114) Correct the "voted for this" string in the budgets component (#10113) Fix filter URL not updated with the text search input (#9618) Improve README design and contents (#10065)
This was referenced Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When the filter forms are submitted manually by pressing the "search" button or enter within the search input, i.e. when doing a text search, the URL is not updated. This fixes the issue.
📌 Related Issues
Testing