Update bulletin board to 0.24 for Ruby 3.1 compatibility#9766
Merged
andreslucena merged 37 commits intodecidim:developfrom Nov 18, 2022
Merged
Update bulletin board to 0.24 for Ruby 3.1 compatibility#9766andreslucena merged 37 commits intodecidim:developfrom
andreslucena merged 37 commits intodecidim:developfrom
Conversation
This reverts commit 96326e0.
…he exe" This reverts commit 464b684.
Requiring bundler can cause the following errors: `uninitialized constant Gem::BundlerVersionFinder (NameError)` To avoid this, do not require bundler in the generators classes.
This reverts commit 2eb3e45.
This reverts commit db39025.
This reverts commit 2eb3e45.
This reverts commit 00b2fd3.
This reverts commit 9890b60.
Contributor
Author
|
I had a many problems updating bundler to $ gem install bundler -v 2.2.31
$ bundle update --conservative decidim-bulletin_board voting_schemes-dummy voting_schemes-electionguard jwtThis is the only way I got the build to pass both locally and in the CI. I tried many things for updating bundler and the "system" gems at the CI running I believe either bundler For search engines and for further inspection, the errors that I encountered had the following kind of error messages:
For further information, both of these issues happened under RubyGems |
Contributor
Author
|
Another note is that I found this issue still running Bulletin Board under OpenSSL 3.0: This still needs to be merged and released before we can get the ruby client working under OpenSSL 3 that Decidim is depending on. |
This was referenced Sep 20, 2022
andreslucena
approved these changes
Oct 10, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
LGTM 👍🏽
Do you think we should merge with develop just to be sure @ahukkanen, as this PR wasn't updated on the last month?
andreslucena
requested changes
Oct 10, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
Nevermind my last comment. I've just seen that we have conflicts to resolve, can you do that @ahukkanen?
andreslucena
approved these changes
Nov 18, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
Tried it locally as a final check and it doesn't give the SSL error anymore.
LGTM 👍🏽
alecslupu
pushed a commit
to i-need-another-coffee/decidim
that referenced
this pull request
Nov 18, 2022
* Update bulletin board to 0.24 * Update the target bundler version in the Gemfile.lock * Update bundler in the Gemfile.lock to the latest * Try to update system gems for the generators workflow * Experiment with gem cleanup in the failing CI * Update the bundler development dependencies * Update the bundler in Dockerfile.design * Try clearing bundle cache at the CI * Revert "Try clearing bundle cache at the CI" This reverts commit 96326e0. * Try re-generating Gemfile.locks * Try defining bundler in the Gemfile as a requirement * Add bundler version as a debug output when running the decidim exe * Require bundler in the decidim exe * Remove the bundler version debug from decidim exe * Add debug information for Rubygems version and load path in the exe * Revert "Add debug information for Rubygems version and load path in the exe" This reverts commit 464b684. * Do not require bundler to avoid runtime issues at CI Requiring bundler can cause the following errors: `uninitialized constant Gem::BundlerVersionFinder (NameError)` To avoid this, do not require bundler in the generators classes. * Revert "Do not require bundler to avoid runtime issues at CI" This reverts commit 2eb3e45. * Revert "Try defining bundler in the Gemfile as a requirement" This reverts commit db39025. * Revert "Do not require bundler to avoid runtime issues at CI" This reverts commit 2eb3e45. * Add ruby to the Gemfile.lock platforms * Remove x86_64-linux from the Gemfile.lock platforms * Revery Gemfile.locks and try conservative update of gems * Revert "Update the bundler in Dockerfile.design" This reverts commit 00b2fd3. * Revert "Update the bundler development dependencies" This reverts commit 9890b60. * Update design app Gemfile.lock * Update bundler in the Gemfile.locks * Remove the --no-document flag from the gem update --system call * Downgrade bundler * Remove system gems update from the generators CI * Update bulletin board and votng schemes to 0.24.1 * Update to bulletin board 0.24.1 in CI * Make elections CI run under Ubuntu 22.04 * Revert Gemfile locks * Concervative update for bulletin board, voting schemes and jwt
Quentinchampenois
pushed a commit
to Quentinchampenois/decidim
that referenced
this pull request
Nov 23, 2022
* Update bulletin board to 0.24 * Update the target bundler version in the Gemfile.lock * Update bundler in the Gemfile.lock to the latest * Try to update system gems for the generators workflow * Experiment with gem cleanup in the failing CI * Update the bundler development dependencies * Update the bundler in Dockerfile.design * Try clearing bundle cache at the CI * Revert "Try clearing bundle cache at the CI" This reverts commit 96326e0. * Try re-generating Gemfile.locks * Try defining bundler in the Gemfile as a requirement * Add bundler version as a debug output when running the decidim exe * Require bundler in the decidim exe * Remove the bundler version debug from decidim exe * Add debug information for Rubygems version and load path in the exe * Revert "Add debug information for Rubygems version and load path in the exe" This reverts commit 464b684. * Do not require bundler to avoid runtime issues at CI Requiring bundler can cause the following errors: `uninitialized constant Gem::BundlerVersionFinder (NameError)` To avoid this, do not require bundler in the generators classes. * Revert "Do not require bundler to avoid runtime issues at CI" This reverts commit 2eb3e45. * Revert "Try defining bundler in the Gemfile as a requirement" This reverts commit db39025. * Revert "Do not require bundler to avoid runtime issues at CI" This reverts commit 2eb3e45. * Add ruby to the Gemfile.lock platforms * Remove x86_64-linux from the Gemfile.lock platforms * Revery Gemfile.locks and try conservative update of gems * Revert "Update the bundler in Dockerfile.design" This reverts commit 00b2fd3. * Revert "Update the bundler development dependencies" This reverts commit 9890b60. * Update design app Gemfile.lock * Update bundler in the Gemfile.locks * Remove the --no-document flag from the gem update --system call * Downgrade bundler * Remove system gems update from the generators CI * Update bulletin board and votng schemes to 0.24.1 * Update to bulletin board 0.24.1 in CI * Make elections CI run under Ubuntu 22.04 * Revert Gemfile locks * Concervative update for bulletin board, voting schemes and jwt
entantoencuanto
added a commit
that referenced
this pull request
Nov 28, 2022
* develop: Redesign: verifications (#9759) Fix machine translations at the API (#9652) Add title and description to the attachment API type (#10114) Correct the "voted for this" string in the budgets component (#10113) Fix filter URL not updated with the text search input (#9618) Improve README design and contents (#10065) Update bulletin board to 0.24 for Ruby 3.1 compatibility (#9766) Fix some oversights in the release notes for the next release (#10078) Fix bug regarding user group moderation action logs (#10085) Fix wrong capitalization in i18n values and add missing keys (#10072) Enhance templates engine (#10015) Add slash in PR linter configuration (#10074) Allow blocking a UserGroup (#10021) Enable newsletters for admin on seeds (#10073)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
After the Ruby 3.1 upgrade (#9449) the
decidim-electionsgem is broken under some OSes because bulletin board does not support OpenSSL 3.0 as explained at #9626.The underlying reason was the
jwtdependency which just released a new version 2.5.0 with OpenSSL 3.0 support. This is shipped with bulletin board 0.24.0. And problems fixed with 0.24.1.📌 Related Issues
Testing
See #9626.