Fix hidden error messages on the registration form#9625
Merged
andreslucena merged 1 commit intodecidim:developfrom Sep 13, 2022
Merged
Fix hidden error messages on the registration form#9625andreslucena merged 1 commit intodecidim:developfrom
andreslucena merged 1 commit intodecidim:developfrom
Conversation
andreslucena
approved these changes
Sep 13, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
Confirmed that this is working as expected.
Comparing it on how it was when the original description screenshot was made, now after merging with the latest develop, the design is a bit broken:
(See the highlighted text to see the alert).
Just to be sure, I also checked it with the new redesign, that's a bit less broken:
So, just seeing the alert of this PR - and ignoring the rest of the page, LGTM 👍🏽
Contributor
Author
|
FYI: Most of the redesigned views are broken with the old layout. They are just "functional" in the sense that the tests are passing with the old Foundation layout. Until redesign is completed and enabled globally, this problem will persist in the |
Member
Ah, ok, I thought so! Just wanted a confirmation that this isn't only happening in my machine 👍🏽 |
entantoencuanto
added a commit
that referenced
this pull request
Sep 13, 2022
* develop: Add missing character on code block (#9798) Fix hidden error messages on the registration form (#9625) Add documentation about configuring ActiveStorage / dynamic file uploads (#9777) Add documentation section about customizing cells (#9622) Fix hashtags not recognized at the beginning of the string (#9616) Fix version pages showing a HTTP 500 error when the version does not exist (#9615) Fix multitenant organizations stats cache (#9605) Prevent the account edit route through Devise (#9611) Fix iframe disabling producing invalid HTML (#9685) Fix import of images on spaces (#9779) Fix order of last activities (#9756) Fix leaking emails on admin user search controller (#9791) Ignore participatory spaces without models in meetings visible_for scope (#9790)
This was referenced Sep 15, 2022
entantoencuanto
added a commit
that referenced
this pull request
Sep 15, 2022
* develop: (24 commits) Add develop index to the documentation (#9666) Fix initiatives components (#9633) Fix conference speaker avatars (#9643) Update `rokroskar/workflow-run-cleanup-action` GitHub action to v0.3.3 (#9750) Fix character counter for the WYSIWYG editor (#9680) Fix posting comments before the initial load has run (#9614) Fix parallel tests port in use (#9661) Split parallel test coverage reports into their own folders (#9686) Improve admin panel user experience regarding title links and order of actions (#9496) Fix title and description too long in initiatives spec sometimes (#9648) Fix API GraphiQL system spec with newer ChromeDriver (#9642) Add missing character on code block (#9798) Fix hidden error messages on the registration form (#9625) Add documentation about configuring ActiveStorage / dynamic file uploads (#9777) Add documentation section about customizing cells (#9622) Fix hashtags not recognized at the beginning of the string (#9616) Fix version pages showing a HTTP 500 error when the version does not exist (#9615) Fix multitenant organizations stats cache (#9605) Prevent the account edit route through Devise (#9611) Fix iframe disabling producing invalid HTML (#9685) ...
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The registration page does not show the flash alert in case there are errors on the form which can be a confusing experience for the participant. This fixes the issue.
📌 Related Issues
Testing