Split parallel test coverage reports into their own folders#9686
Merged
andreslucena merged 1 commit intodecidim:developfrom Sep 15, 2022
Merged
Conversation
andreslucena
approved these changes
Sep 15, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
Makes perfect sense, thanks for the great explanation 👍🏽
This was referenced Sep 15, 2022
entantoencuanto
added a commit
that referenced
this pull request
Sep 15, 2022
* develop: (24 commits) Add develop index to the documentation (#9666) Fix initiatives components (#9633) Fix conference speaker avatars (#9643) Update `rokroskar/workflow-run-cleanup-action` GitHub action to v0.3.3 (#9750) Fix character counter for the WYSIWYG editor (#9680) Fix posting comments before the initial load has run (#9614) Fix parallel tests port in use (#9661) Split parallel test coverage reports into their own folders (#9686) Improve admin panel user experience regarding title links and order of actions (#9496) Fix title and description too long in initiatives spec sometimes (#9648) Fix API GraphiQL system spec with newer ChromeDriver (#9642) Add missing character on code block (#9798) Fix hidden error messages on the registration form (#9625) Add documentation about configuring ActiveStorage / dynamic file uploads (#9777) Add documentation section about customizing cells (#9622) Fix hashtags not recognized at the beginning of the string (#9616) Fix version pages showing a HTTP 500 error when the version does not exist (#9615) Fix multitenant organizations stats cache (#9605) Prevent the account edit route through Devise (#9611) Fix iframe disabling producing invalid HTML (#9685) ...
Contributor
Author
|
It seems this did not fix the problem after all: Some of the report files could be downloaded from Codecov but some of them give this kind of error: <Error>
<Code>ExpiredToken</Code>
<Message>The provided token has expired.</Message>
<Details>Request signature expired at: 2022-09-15T17:02:41+00:00</Details>
</Error>In that particular run, for example these methods were reported as uncovered: Both of these should be covered by this spec: decidim/decidim-admin/spec/system/static_pages_spec.rb Lines 155 to 241 in c6791f1 But the report from that run could not be uploaded to codecov as the logs show: Here's the same in text format: |
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
ahukkanen
added a commit
to mainio/decidim
that referenced
this pull request
Feb 6, 2023
…ecidim#9686)" This reverts commit dba6811.
alecslupu
pushed a commit
that referenced
this pull request
Feb 14, 2023
* Switch to the official Codecov action v3 * Revert "Split parallel test coverage reports into their own folders (#9686)" This reverts commit dba6811. * Use working-directory instead of the directory argument * Add unique name to the decidim-core coverage reports * Move the working-directory under the with arguments * Remove working-directory as the report is always at the root * Define the flag argument similarly to the old uploader * Remove the legacy coverage uploader * Hard code the CodeCov token to the workflow files
ahukkanen
added a commit
that referenced
this pull request
Mar 1, 2023
* Switch to the official Codecov action v3 * Revert "Split parallel test coverage reports into their own folders (#9686)" This reverts commit dba6811. * Use working-directory instead of the directory argument * Add unique name to the decidim-core coverage reports * Move the working-directory under the with arguments * Remove working-directory as the report is always at the root * Define the flag argument similarly to the old uploader * Remove the legacy coverage uploader * Hard code the CodeCov token to the workflow files
ahukkanen
added a commit
that referenced
this pull request
Mar 1, 2023
* Switch to the official Codecov action v3 * Revert "Split parallel test coverage reports into their own folders (#9686)" This reverts commit dba6811. * Use working-directory instead of the directory argument * Add unique name to the decidim-core coverage reports * Move the working-directory under the with arguments * Remove working-directory as the report is always at the root * Define the flag argument similarly to the old uploader * Remove the legacy coverage uploader * Hard code the CodeCov token to the workflow files
alecslupu
pushed a commit
that referenced
this pull request
Mar 1, 2023
* Switch to the official Codecov action v3 * Revert "Split parallel test coverage reports into their own folders (#9686)" This reverts commit dba6811. * Use working-directory instead of the directory argument * Add unique name to the decidim-core coverage reports * Move the working-directory under the with arguments * Remove working-directory as the report is always at the root * Define the flag argument similarly to the old uploader * Remove the legacy coverage uploader * Hard code the CodeCov token to the workflow files
alecslupu
pushed a commit
that referenced
this pull request
Mar 1, 2023
) * Switch to the official Codecov action for CI (#10344) * Switch to the official Codecov action v3 * Revert "Split parallel test coverage reports into their own folders (#9686)" This reverts commit dba6811. * Use working-directory instead of the directory argument * Add unique name to the decidim-core coverage reports * Move the working-directory under the with arguments * Remove working-directory as the report is always at the root * Define the flag argument similarly to the old uploader * Remove the legacy coverage uploader * Hard code the CodeCov token to the workflow files * Switch to the codecov action at the rest of the workflows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
I started to first improve the unit test coverage on the core but then I bumped into one report where the
Decidim::GroupsControllercoverage was at 0% although all specs had been run correctly during that run.I started to investigate this and I found this issue with the
simplecovwhen used with theparallel_tests:simplecov-ruby/simplecov#1019
This issue seems really close to what we are experiencing with Decidim and the suggested solution is to split the coverage reports for each parallel test run into their separate folders. This way merging should happen at Codecov's side which means that if the
simplecovmerging is buggy, it shouldn't affect our CI coverage reports.Regardless of this, I will still continue on #9684 to add a bit more unit tests.
📌 Related Issues
Testing
We'll just have to see if the coverage reports consistency improves.