Update rokroskar/workflow-run-cleanup-action GitHub action to v0.3.3#9750
Conversation
andreslucena
left a comment
There was a problem hiding this comment.
Great explanation as usual! Just for the consistency and upgrade make sense.
Let's merge it and monitor the next runs and see if we can catch this again.
|
Hi! Long time no see! In my current company we're using the https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency I've been out of the project for a while now so I might have missed any discussion about it, sorry if this has been discussed before! |
|
Hi @mrcasals! Great to see you here 😄 There's a deprecation warning mentioning concurrency at the README. I left it on the Maintainers project, so we don't miss it, but makes sense to migrate to that one. What do you prefer @ahukkanen? Merge this one and migrate to concurrency in the near future? |
|
@andreslucena Yes, I saw that when investigating this but I just wanted to fix the problem before doing any changes in the CI flows. I agree we should eventually migrate to using the |
Great, I'll merge it then |
* develop: (24 commits) Add develop index to the documentation (#9666) Fix initiatives components (#9633) Fix conference speaker avatars (#9643) Update `rokroskar/workflow-run-cleanup-action` GitHub action to v0.3.3 (#9750) Fix character counter for the WYSIWYG editor (#9680) Fix posting comments before the initial load has run (#9614) Fix parallel tests port in use (#9661) Split parallel test coverage reports into their own folders (#9686) Improve admin panel user experience regarding title links and order of actions (#9496) Fix title and description too long in initiatives spec sometimes (#9648) Fix API GraphiQL system spec with newer ChromeDriver (#9642) Add missing character on code block (#9798) Fix hidden error messages on the registration form (#9625) Add documentation about configuring ActiveStorage / dynamic file uploads (#9777) Add documentation section about customizing cells (#9622) Fix hashtags not recognized at the beginning of the string (#9616) Fix version pages showing a HTTP 500 error when the version does not exist (#9615) Fix multitenant organizations stats cache (#9605) Prevent the account edit route through Devise (#9611) Fix iframe disabling producing invalid HTML (#9685) ...
🎩 What? Why?
v0.3.3 of
rokroskar/workflow-run-cleanup-actionseems to have the following fix:rokroskar/workflow-run-cleanup-action#30
I suspect this has something to do with the "Lint PR format" action getting cancelled constantly when the job queue is busy.
And it seems to also make sense because the "Lint PR format" action is the only one using v0.3.2 currently and the other actions are using v0.3.0. So I hope this will fix the issue with this action being constantly cancelled which is frustrating when we have a lot of jobs queued, e.g. during the backports.
This is a continuation for #9499 where I tried to debug this issue unsuccessfully.
📌 Related Issues
Testing
See that the CI action is not cancelled in this PR. When this PR was opened, the job queue was very busy.
EDIT: Actually this is not a trustworthy benchmark because this PR has to be merged first in order for the other PRs not to cancel the Lint run on this PR.