Skip to content

Fix multitenant organizations stats cache#9605

Merged
andreslucena merged 4 commits intodecidim:developfrom
mainio:fix/multitenant-org-stats-cache
Sep 13, 2022
Merged

Fix multitenant organizations stats cache#9605
andreslucena merged 4 commits intodecidim:developfrom
mainio:fix/multitenant-org-stats-cache

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

🎩 What? Why?

When using cache with multitenant organizations, the stats are always the same for all organizations after they are cached.

📌 Related Issues

Testing

  • Run two organizations with some data that differs between the organizations
  • Enable cache (bundle exec rails dev:cache)
  • Request the first organization
  • Request the second organization
  • See that correct stats are presented on the home page

@ahukkanen ahukkanen added type: fix PRs that implement a fix for a bug module: core labels Jul 25, 2022
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it when we have just a line of code and a new spec file 😄

@andreslucena andreslucena merged commit 69bb7c1 into decidim:develop Sep 13, 2022
@ahukkanen ahukkanen deleted the fix/multitenant-org-stats-cache branch September 13, 2022 11:14
entantoencuanto added a commit that referenced this pull request Sep 13, 2022
* develop:
  Add missing character on code block (#9798)
  Fix hidden error messages on the registration form (#9625)
  Add documentation about configuring ActiveStorage / dynamic file uploads (#9777)
  Add documentation section about customizing cells (#9622)
  Fix hashtags not recognized at the beginning of the string (#9616)
  Fix version pages showing a HTTP 500 error when the version does not exist (#9615)
  Fix multitenant organizations stats cache (#9605)
  Prevent the account edit route through Devise (#9611)
  Fix iframe disabling producing invalid HTML (#9685)
  Fix import of images on spaces (#9779)
  Fix order of last activities (#9756)
  Fix leaking emails on admin user search controller (#9791)
  Ignore participatory spaces without models in meetings visible_for scope (#9790)
entantoencuanto added a commit that referenced this pull request Sep 15, 2022
* develop: (24 commits)
  Add develop index to the documentation (#9666)
  Fix initiatives components (#9633)
  Fix conference speaker avatars (#9643)
  Update `rokroskar/workflow-run-cleanup-action` GitHub action to v0.3.3 (#9750)
  Fix character counter for the WYSIWYG editor (#9680)
  Fix posting comments before the initial load has run (#9614)
  Fix parallel tests port in use (#9661)
  Split parallel test coverage reports into their own folders (#9686)
  Improve admin panel user experience regarding title links and order of actions (#9496)
  Fix title and description too long in initiatives spec sometimes (#9648)
  Fix API GraphiQL system spec with newer ChromeDriver (#9642)
  Add missing character on code block (#9798)
  Fix hidden error messages on the registration form (#9625)
  Add documentation about configuring ActiveStorage / dynamic file uploads (#9777)
  Add documentation section about customizing cells (#9622)
  Fix hashtags not recognized at the beginning of the string (#9616)
  Fix version pages showing a HTTP 500 error when the version does not exist (#9615)
  Fix multitenant organizations stats cache (#9605)
  Prevent the account edit route through Devise (#9611)
  Fix iframe disabling producing invalid HTML (#9685)
  ...
eliegaboriau pushed a commit to eliegaboriau/decidim that referenced this pull request Oct 25, 2022
* Fix same stats cache for multitenant organizations

* Add specs for the stats cell

* Rubocop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Organisation statistics are displayed of the wrong tenant

2 participants