Ignore participatory spaces without models in meetings visible_for scope#9790
Merged
ahukkanen merged 2 commits intodecidim:developfrom Sep 12, 2022
Merged
Conversation
Contributor
Author
|
May I port this to 0.26. 0.27? |
Contributor
Yes please, both. Can you please use the backporter script for this. Run |
entantoencuanto
added a commit
that referenced
this pull request
Sep 13, 2022
* develop: Add missing character on code block (#9798) Fix hidden error messages on the registration form (#9625) Add documentation about configuring ActiveStorage / dynamic file uploads (#9777) Add documentation section about customizing cells (#9622) Fix hashtags not recognized at the beginning of the string (#9616) Fix version pages showing a HTTP 500 error when the version does not exist (#9615) Fix multitenant organizations stats cache (#9605) Prevent the account edit route through Devise (#9611) Fix iframe disabling producing invalid HTML (#9685) Fix import of images on spaces (#9779) Fix order of last activities (#9756) Fix leaking emails on admin user search controller (#9791) Ignore participatory spaces without models in meetings visible_for scope (#9790)
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
…ope (decidim#9790) * ignore participatory spaces without models in highlighted elements * add a test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
We've found out that it is possible to define a participatory space not associated with a model (for instance see the (decidim-calendar)[https://github.com/alabs/decidim-module-calendar] module).
But some methods are not prepared for that, in particular the scope
visible_for?for the meetings model.This should fix this by ignoring any participatory space without models in that scope.
Please describe your pull request.
📌 Related Issues
Link your PR to an issue
Testing
To test the bug, install the decidim calendar module, and try to edit a meeting as a user (not admin), it should give you a 500 error.
📷 Screenshots
N/A