Fix import of images on spaces#9779
Merged
ahukkanen merged 5 commits intodecidim:developfrom Sep 13, 2022
Merged
Conversation
ahukkanen
requested changes
Sep 9, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
Great fix, thanks a lot!
I have added one suggestion below to keep the code base consistent + if you could also check my question regarding the changed test data, it would be appreciated.
decidim-assemblies/app/serializers/decidim/assemblies/assembly_importer.rb
Outdated
Show resolved
Hide resolved
Contributor
|
If you are doing any pushes in the following days, don't worry if the generators or performance tests are failing. This is being fixed at #9785. |
afe02f5 to
69c0f03
Compare
Fix assemblies and process images importation
69c0f03 to
567bbca
Compare
Contributor
|
Hi @ahukkanen, can you review it again? thanks |
ahukkanen
requested changes
Sep 12, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
Looking good!
I've just added couple more suggestions for final cleanup. After these are addressed, I think it's ready to be merged!
decidim-participatory_processes/spec/system/admin/admin_import_participatory_process_spec.rb
Outdated
Show resolved
Hide resolved
decidim-dev/lib/decidim/dev/assets/participatory_processes.json
Outdated
Show resolved
Hide resolved
567bbca to
1a63308
Compare
entantoencuanto
added a commit
that referenced
this pull request
Sep 13, 2022
* develop: Add missing character on code block (#9798) Fix hidden error messages on the registration form (#9625) Add documentation about configuring ActiveStorage / dynamic file uploads (#9777) Add documentation section about customizing cells (#9622) Fix hashtags not recognized at the beginning of the string (#9616) Fix version pages showing a HTTP 500 error when the version does not exist (#9615) Fix multitenant organizations stats cache (#9605) Prevent the account edit route through Devise (#9611) Fix iframe disabling producing invalid HTML (#9685) Fix import of images on spaces (#9779) Fix order of last activities (#9756) Fix leaking emails on admin user search controller (#9791) Ignore participatory spaces without models in meetings visible_for scope (#9790)
Contributor
Author
|
@ahukkanen do you want us to backport this fix to |
This was referenced Sep 15, 2022
Contributor
|
@tramuntanal We are just preparing for RC2 release, so I went ahead and created the backports already. |
Contributor
Author
|
Thank you @ahukkanen !! |
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
* Fix import hero and banner images in participatory process Fix assemblies and process images importation * Remove uneeded yarn.lock * TEST: Make tests succeed * Refactor bugfix * Rename helper test function Co-authored-by: Laura Jaime <laura.jv@coditramuntana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
After the migration from Carrierwave to ActiveStorage, when importing a Participatory Process or an Assembly from a json file, the import succeeds but the attachments are not downloaded.
📌 Related Issues
Link your PR to an issue
No related issue found.
Testing
The same for assemblies.