Skip to content

Fix API GraphiQL system spec with newer ChromeDriver#9642

Merged
andreslucena merged 1 commit intodecidim:developfrom
mainio:frontport/9556
Sep 14, 2022
Merged

Fix API GraphiQL system spec with newer ChromeDriver#9642
andreslucena merged 1 commit intodecidim:developfrom
mainio:frontport/9556

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

🎩 What? Why?

Frontports the fix at #9556 to develop. I initially thought it wouldn't be needed but apparently it is.

I had this spec failing at #9639
Failure image

📌 Related Issues

…m#9556)

* Fix the graphiql system spec for 0.26 with newer ChromeDriver

* Remove unnecessary expectation from the spec
@ahukkanen ahukkanen added type: internal PRs that aren't necessary to add to the CHANGELOG for implementers module: api labels Aug 1, 2022
@ahukkanen ahukkanen changed the title Fix API GraphiQL system spec for 0.26 with newer ChromeDriver Fix API GraphiQL system spec with newer ChromeDriver Aug 1, 2022
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 We should also backport this to v0.27 for consistency

@andreslucena andreslucena merged commit b01ac18 into decidim:develop Sep 14, 2022
@ahukkanen ahukkanen deleted the frontport/9556 branch September 14, 2022 08:45
entantoencuanto added a commit that referenced this pull request Sep 15, 2022
* develop: (24 commits)
  Add develop index to the documentation (#9666)
  Fix initiatives components (#9633)
  Fix conference speaker avatars (#9643)
  Update `rokroskar/workflow-run-cleanup-action` GitHub action to v0.3.3 (#9750)
  Fix character counter for the WYSIWYG editor (#9680)
  Fix posting comments before the initial load has run (#9614)
  Fix parallel tests port in use (#9661)
  Split parallel test coverage reports into their own folders (#9686)
  Improve admin panel user experience regarding title links and order of actions (#9496)
  Fix title and description too long in initiatives spec sometimes (#9648)
  Fix API GraphiQL system spec with newer ChromeDriver (#9642)
  Add missing character on code block (#9798)
  Fix hidden error messages on the registration form (#9625)
  Add documentation about configuring ActiveStorage / dynamic file uploads (#9777)
  Add documentation section about customizing cells (#9622)
  Fix hashtags not recognized at the beginning of the string (#9616)
  Fix version pages showing a HTTP 500 error when the version does not exist (#9615)
  Fix multitenant organizations stats cache (#9605)
  Prevent the account edit route through Devise (#9611)
  Fix iframe disabling producing invalid HTML (#9685)
  ...
eliegaboriau pushed a commit to eliegaboriau/decidim that referenced this pull request Oct 25, 2022
* Fix the graphiql system spec for 0.26 with newer ChromeDriver

* Remove unnecessary expectation from the spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: api type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants