Fix API GraphiQL system spec for 0.26 with newer ChromeDriver#9556
Merged
andreslucena merged 3 commits intodecidim:release/0.26-stablefrom Jul 11, 2022
Merged
Conversation
Contributor
Author
|
Note that some of the core specs will fail until #9553 is merged. |
Member
@ahukkanen that's already merged, you can merge/rebase so that's fixed, and we can merge this one |
Contributor
Author
Done @andreslucena. |
andreslucena
pushed a commit
that referenced
this pull request
Jul 13, 2022
* Fix the graphiql system spec for 0.26 with newer ChromeDriver * Remove unnecessary expectation from the spec
Merged
12 tasks
ahukkanen
added a commit
to mainio/decidim
that referenced
this pull request
Jul 31, 2022
…m#9556) * Fix the graphiql system spec for 0.26 with newer ChromeDriver * Remove unnecessary expectation from the spec
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This spec seems to be flaky at the
release/0.26-stablebranch with newer ChromeDriver versions.The reason for the spec not working always is that the execute button is being clicked before the interface is listening to that click causing the query not to be executed.
This fixes the issue by waiting that the default query appears on the screen before clicking the execute button.
This is only fixed for 0.26 as this problem does not seem to exist at
developwith the newer version of the GraphiQL interface.Testing
Run the spec 20 times in a row and see that all runs should pass.