Skip to content

Add redesign for responsive public profile navigation tabs#6032

Merged
ivan-mr merged 9 commits intodevelopfrom
fix/responsive_redesing_for_navigation_public_profile_tabs
Apr 30, 2020
Merged

Add redesign for responsive public profile navigation tabs#6032
ivan-mr merged 9 commits intodevelopfrom
fix/responsive_redesing_for_navigation_public_profile_tabs

Conversation

@ivan-mr
Copy link
Copy Markdown
Contributor

@ivan-mr ivan-mr commented Apr 27, 2020

🎩 What? Why?

When we access to a public profile with a mobile device, the navigation tab isn't showed properly

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • If there's a new public field, add it to GraphQL API
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

📷 Screenshots (optional)

Captura de pantalla de 2020-04-27 19-25-40

Captura de pantalla de 2020-04-27 19-25-50

@ivan-mr ivan-mr linked an issue Apr 27, 2020 that may be closed by this pull request
@jesusdb jesusdb self-requested a review April 28, 2020 14:28
@jesusdb jesusdb self-requested a review April 29, 2020 13:48
jesusdb
jesusdb previously approved these changes Apr 29, 2020
@Leusev Leusev self-requested a review April 30, 2020 12:41
Copy link
Copy Markdown
Contributor

@Leusev Leusev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @ivan-mr
it seems perfect for me!

@ivan-mr ivan-mr merged commit fb329c6 into develop Apr 30, 2020
@ivan-mr ivan-mr deleted the fix/responsive_redesing_for_navigation_public_profile_tabs branch April 30, 2020 13:40
ace pushed a commit to aspgems/decidim that referenced this pull request May 5, 2020
* develop: (29 commits)
  Update Conversations design with decidim-design UI (decidim#6008)
  Add counter of active users to admin dashboard (decidim#5907)
  Show activity graphs on admin dashboard (decidim#6030)
  Update sassc gem version (decidim#6062)
  Fix generator Gemfile after puma upgrade (decidim#6060)
  New Crowdin translations (decidim#6059)
  Add Slovak as a new language (decidim#6039)
  Remove all tests for i18n PRs (decidim#6061)
  Update move up and down buttons after dragging questions when managing questionnaire (decidim#5947)
  Fix using Decidim as a provider for omniauth authentication (decidim#6042)
  Add redesign for responsive public profile navigation tabs (decidim#6032)
  Add versioning pages to initiatives (decidim#5935)
  Notify users when roles get assigned (decidim#5886)
  Improve the budget page and the project card (decidim#5809)
  New Crowdin translations (decidim#6050)
  New Crowdin translations (decidim#6046)
  Ignore jobs on locales branches (decidim#6047)
  Automatic task for deleting Meeting Inscription data (decidim#5989)
  New Crowdin translations (decidim#5877)
  Ignore builds on Crowdin PRs (decidim#6037)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Public profile navigation broken on narrow mobile screens

3 participants