Skip to content

Update move up and down buttons after dragging questions when managing questionnaire#5947

Merged
jesusdb merged 5 commits intodecidim:developfrom
Platoniq:fix/move-buttons-when-dragging-questions
May 4, 2020
Merged

Update move up and down buttons after dragging questions when managing questionnaire#5947
jesusdb merged 5 commits intodecidim:developfrom
Platoniq:fix/move-buttons-when-dragging-questions

Conversation

@verarojman
Copy link
Copy Markdown
Contributor

@verarojman verarojman commented Apr 9, 2020

Note: This is a new version of #5909 to get rid of some unwanted commits.

🎩 What? Why?

This PR fixes "Move up" and "Move down" buttons when editing a questionnaire to make them correctly update after dragging questions to reorder them.

📋 Subtasks

  • Add CHANGELOG entry

📷 Screenshots

Before:

Before


After:

After

@jesusdb
Copy link
Copy Markdown
Contributor

jesusdb commented Apr 27, 2020

Hello @verarojman, has this been approved by @decidim/product?

@microstudi
Copy link
Copy Markdown
Contributor

This fixes a bug @jesusdb

@jesusdb jesusdb self-requested a review April 29, 2020 13:20
@jesusdb
Copy link
Copy Markdown
Contributor

jesusdb commented Apr 29, 2020

Please, solve the changelog conflict to approve 👍

@verarojman
Copy link
Copy Markdown
Contributor Author

Done @jesusdb!

@jesusdb jesusdb merged commit 435d69b into decidim:develop May 4, 2020
ace pushed a commit to aspgems/decidim that referenced this pull request May 5, 2020
* develop: (29 commits)
  Update Conversations design with decidim-design UI (decidim#6008)
  Add counter of active users to admin dashboard (decidim#5907)
  Show activity graphs on admin dashboard (decidim#6030)
  Update sassc gem version (decidim#6062)
  Fix generator Gemfile after puma upgrade (decidim#6060)
  New Crowdin translations (decidim#6059)
  Add Slovak as a new language (decidim#6039)
  Remove all tests for i18n PRs (decidim#6061)
  Update move up and down buttons after dragging questions when managing questionnaire (decidim#5947)
  Fix using Decidim as a provider for omniauth authentication (decidim#6042)
  Add redesign for responsive public profile navigation tabs (decidim#6032)
  Add versioning pages to initiatives (decidim#5935)
  Notify users when roles get assigned (decidim#5886)
  Improve the budget page and the project card (decidim#5809)
  New Crowdin translations (decidim#6050)
  New Crowdin translations (decidim#6046)
  Ignore jobs on locales branches (decidim#6047)
  Automatic task for deleting Meeting Inscription data (decidim#5989)
  New Crowdin translations (decidim#5877)
  Ignore builds on Crowdin PRs (decidim#6037)
  ...
microstudi pushed a commit to Platoniq/decidim that referenced this pull request Jul 8, 2020
…g questionnaire (decidim#5947)

* Update move up and down buttons after dragging questions when managing a questionnaire in admin

* Update changelog
@microstudi microstudi mentioned this pull request Jul 23, 2020
13 tasks
microstudi added a commit to Platoniq/decidim that referenced this pull request Jul 23, 2020
…g questionnaire (decidim#5947)

* Update move up and down buttons after dragging questions when managing a questionnaire in admin

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants