Skip to content

Update Conversations design with decidim-design UI#6008

Merged
tramuntanal merged 10 commits intodevelopfrom
feat/update_conversations_design
May 5, 2020
Merged

Update Conversations design with decidim-design UI#6008
tramuntanal merged 10 commits intodevelopfrom
feat/update_conversations_design

Conversation

@Leusev
Copy link
Copy Markdown
Contributor

@Leusev Leusev commented Apr 21, 2020

🎩 What? Why?

Adds a new user interface, with the decidim-design repository's new interface design.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

📷 Screenshots (optional)

Before

image

After

image

Before

image

After

image

@Leusev Leusev requested review from jesusdb and tramuntanal April 21, 2020 13:36
@Leusev Leusev assigned Leusev and unassigned Leusev Apr 21, 2020
@jesusdb jesusdb self-requested a review April 28, 2020 08:04
Copy link
Copy Markdown
Contributor

@jesusdb jesusdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved, but later I saw there were some failing tests. Could you please check it?

@Leusev Leusev requested a review from jesusdb April 30, 2020 12:22
@Leusev
Copy link
Copy Markdown
Contributor Author

Leusev commented May 5, 2020

Hi @jesusdb
tests fixed yet! Can you review please?
Thanks!

Copy link
Copy Markdown
Contributor

@ivan-mr ivan-mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Copy Markdown
Contributor

@jesusdb jesusdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, good job! 😄

@tramuntanal tramuntanal linked an issue May 5, 2020 that may be closed by this pull request
1 task
@tramuntanal tramuntanal merged commit 7b12c8f into develop May 5, 2020
@tramuntanal tramuntanal deleted the feat/update_conversations_design branch May 5, 2020 13:55
ace pushed a commit to aspgems/decidim that referenced this pull request May 5, 2020
* develop: (29 commits)
  Update Conversations design with decidim-design UI (decidim#6008)
  Add counter of active users to admin dashboard (decidim#5907)
  Show activity graphs on admin dashboard (decidim#6030)
  Update sassc gem version (decidim#6062)
  Fix generator Gemfile after puma upgrade (decidim#6060)
  New Crowdin translations (decidim#6059)
  Add Slovak as a new language (decidim#6039)
  Remove all tests for i18n PRs (decidim#6061)
  Update move up and down buttons after dragging questions when managing questionnaire (decidim#5947)
  Fix using Decidim as a provider for omniauth authentication (decidim#6042)
  Add redesign for responsive public profile navigation tabs (decidim#6032)
  Add versioning pages to initiatives (decidim#5935)
  Notify users when roles get assigned (decidim#5886)
  Improve the budget page and the project card (decidim#5809)
  New Crowdin translations (decidim#6050)
  New Crowdin translations (decidim#6046)
  Ignore jobs on locales branches (decidim#6047)
  Automatic task for deleting Meeting Inscription data (decidim#5989)
  New Crowdin translations (decidim#5877)
  Ignore builds on Crowdin PRs (decidim#6037)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Conversations design with decidim-design UI

5 participants