Conversation
ed6c946 to
87ef2df
Compare
|
Hello, @tramuntanal @carolromero this ready to be reviewed and merged :) |
|
@virgile-dev that's ok from @decidim/product, thanks! |
tramuntanal
left a comment
There was a problem hiding this comment.
Hi @ace good job here!
I just see that we don't want to to add more dependencies to decidim-core, even if these are test dependencies.
The ones that we have now are accidental. Check my comments, we can discuss it if you have any question
decidim-core/spec/factories.rb
Outdated
| require "decidim/meetings/test/factories" | ||
| require "decidim/accountability/test/factories" | ||
| require "decidim/system/test/factories" | ||
| require "decidim/initiatives/test/factories" |
There was a problem hiding this comment.
Do we really need to add this dependecy to decidim core?
Our objective is to get rid of accountability and meetings not to add more dependencies 😄
| context "when diffing a translatable attribute that has empty strings" do | ||
| let(:title) { { en: "English title", ca: "Catalan title", es: "" } } | ||
| let(:item) { create(:result, title: title) } | ||
| let(:item) { create(:initiative, title: title) } |
There was a problem hiding this comment.
We should extract an example and include it in a spec in initiatives please
There was a problem hiding this comment.
I'm removing both changes above. They were mostly me trying to 'fix' a red in CI coverage tasks that was not really because of the changes.
Co-Authored-By: Oliver Valls <tramuntanal@gmail.com>
* Add versioning pages to initiatives * Add specs for versioning pages * Add CHANGELOG entry * Normalize i18n file (hopefully) * Use initiatives in diff cell test to test if branch in diff renderer class detection * Remove unrelated lines from Changelog * Undo changes on core
|
This PR was squashed and merged to |
* develop: (29 commits) Update Conversations design with decidim-design UI (decidim#6008) Add counter of active users to admin dashboard (decidim#5907) Show activity graphs on admin dashboard (decidim#6030) Update sassc gem version (decidim#6062) Fix generator Gemfile after puma upgrade (decidim#6060) New Crowdin translations (decidim#6059) Add Slovak as a new language (decidim#6039) Remove all tests for i18n PRs (decidim#6061) Update move up and down buttons after dragging questions when managing questionnaire (decidim#5947) Fix using Decidim as a provider for omniauth authentication (decidim#6042) Add redesign for responsive public profile navigation tabs (decidim#6032) Add versioning pages to initiatives (decidim#5935) Notify users when roles get assigned (decidim#5886) Improve the budget page and the project card (decidim#5809) New Crowdin translations (decidim#6050) New Crowdin translations (decidim#6046) Ignore jobs on locales branches (decidim#6047) Automatic task for deleting Meeting Inscription data (decidim#5989) New Crowdin translations (decidim#5877) Ignore builds on Crowdin PRs (decidim#6037) ...
🎩 What? Why?
Add versioning pages to initiatives
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)