Merged
Conversation
tramuntanal
approved these changes
May 4, 2020
Contributor
Author
|
@tramuntanal PR is green! Can you merge it? 😄 |
ace
pushed a commit
to aspgems/decidim
that referenced
this pull request
May 5, 2020
* develop: (29 commits) Update Conversations design with decidim-design UI (decidim#6008) Add counter of active users to admin dashboard (decidim#5907) Show activity graphs on admin dashboard (decidim#6030) Update sassc gem version (decidim#6062) Fix generator Gemfile after puma upgrade (decidim#6060) New Crowdin translations (decidim#6059) Add Slovak as a new language (decidim#6039) Remove all tests for i18n PRs (decidim#6061) Update move up and down buttons after dragging questions when managing questionnaire (decidim#5947) Fix using Decidim as a provider for omniauth authentication (decidim#6042) Add redesign for responsive public profile navigation tabs (decidim#6032) Add versioning pages to initiatives (decidim#5935) Notify users when roles get assigned (decidim#5886) Improve the budget page and the project card (decidim#5809) New Crowdin translations (decidim#6050) New Crowdin translations (decidim#6046) Ignore jobs on locales branches (decidim#6047) Automatic task for deleting Meeting Inscription data (decidim#5989) New Crowdin translations (decidim#5877) Ignore builds on Crowdin PRs (decidim#6037) ...
tramuntanal
pushed a commit
that referenced
this pull request
May 6, 2020
* Remove all tests for i18n PRs * Fix branch name
mrcasals
added a commit
that referenced
this pull request
May 19, 2020
* Remove all tests for i18n PRs * Fix branch name
microstudi
pushed a commit
that referenced
this pull request
May 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
After some attempts (see #6037 and related), this PR fixes the code to avoid running tests for i18n PRs. It actually removes tests from any PR that comes from a branch whose name starts with
l10n_, so please don't use that value for normal code PRs.You can check the code behavior in this test PR I created: mrcasals/test-github-actions#4
📌 Related Issues
📋 Subtasks
None