Skip to content

Fix using Decidim as a provider for omniauth authentication#6042

Merged
tramuntanal merged 8 commits intodevelopfrom
fix/decidim-oauth-config
Apr 30, 2020
Merged

Fix using Decidim as a provider for omniauth authentication#6042
tramuntanal merged 8 commits intodevelopfrom
fix/decidim-oauth-config

Conversation

@microstudi
Copy link
Copy Markdown
Contributor

@microstudi microstudi commented Apr 28, 2020

🎩 What? Why?

When using decidim omniauth method from https://github.com/decidim/omniauth-decidim some parameters must be prepared due the changes of #5516.

With this OAuth login with Decidim instances should work again.

Changes:

  • Add decidim provider to devault omniauth initializer
  • Relax force SSL redirect in Development (otherwise is very painful to test in localhost)
  • System translations
  • Use defaults from secrets if configured

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • If there's a new public field, add it to GraphQL API
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

📷 Screenshots (optional)

Description

@tramuntanal tramuntanal marked this pull request as ready for review April 29, 2020 16:24
tramuntanal
tramuntanal previously approved these changes Apr 29, 2020
@microstudi microstudi changed the title Add decidim method to omniauth initializer Fix using Decidim as a provider for omniauth authentication Apr 29, 2020
@jesusdb jesusdb self-requested a review April 30, 2020 14:06
@tramuntanal tramuntanal merged commit 87a5075 into develop Apr 30, 2020
@tramuntanal tramuntanal deleted the fix/decidim-oauth-config branch April 30, 2020 14:18
ace pushed a commit to aspgems/decidim that referenced this pull request May 5, 2020
* develop: (29 commits)
  Update Conversations design with decidim-design UI (decidim#6008)
  Add counter of active users to admin dashboard (decidim#5907)
  Show activity graphs on admin dashboard (decidim#6030)
  Update sassc gem version (decidim#6062)
  Fix generator Gemfile after puma upgrade (decidim#6060)
  New Crowdin translations (decidim#6059)
  Add Slovak as a new language (decidim#6039)
  Remove all tests for i18n PRs (decidim#6061)
  Update move up and down buttons after dragging questions when managing questionnaire (decidim#5947)
  Fix using Decidim as a provider for omniauth authentication (decidim#6042)
  Add redesign for responsive public profile navigation tabs (decidim#6032)
  Add versioning pages to initiatives (decidim#5935)
  Notify users when roles get assigned (decidim#5886)
  Improve the budget page and the project card (decidim#5809)
  New Crowdin translations (decidim#6050)
  New Crowdin translations (decidim#6046)
  Ignore jobs on locales branches (decidim#6047)
  Automatic task for deleting Meeting Inscription data (decidim#5989)
  New Crowdin translations (decidim#5877)
  Ignore builds on Crowdin PRs (decidim#6037)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error using omniauth custom providers

3 participants