Applies the semgrep rule for return-arg-fmt to Solidity tests.

…hereum-optimism#12606)

* optimize the doc

* small fix

* reomve outdated content

…imism#12602)

* inclusion proof

* fix test

* add inclusion proof

* goimports

Bumps the number of heavy fuzz runs to 20k. 10k recently missed a
flake so bumping to 20k to try to avoid that in the future. Not
perfect but it will reduce the probability a bit. Developers can
still manually set the number of fuzz runs for a particular test
with annotations if 20k is too high.

This test fails a lot when executors are under load. This PR changes the test to find the first block with more than one batcher transaction in it, which should be sufficient to assert that the batcher is submitting multiple transactions at once.

…imism#12607)

Updates semgrep config to apply expectRevert to tests. Fixes a few
instances where this wasn't being followed.

* feat: support permit2 on superchainweth

* chore: run pre-pr

---------

Co-authored-by: agusduha <agusnduha@gmail.com>
Co-authored-by: gotzenx <78360669+gotzenx@users.noreply.github.com>

…ene format (ethereum-optimism#12619)

op-deployer generates rollup configs, and those rollup configs are currently broken for older versions of op-node that don't support reading the EIP1559Params field in the SystemConfig. This PR adds a meta field within the SystemConfig that, when enabled, marshals the SystemConfig without the EIP1559Params field. This solution is backwards-compatible and minimally invasive, requiring no changes to the consensus-critical code that consumes the SystemConfig elsewhere.

Closes ethereum-optimism#12615.

* op-program: Compile op-program for Cannon64

* op-program: Update comment

…ism#12622)

Co-authored-by: axelKingsley <axel.kingsley@gmail.com>
Co-authored-by: Tyler Smith <mail@tcry.pt>

* op-supervisor: DB improvements for cross-safe updates

Co-authored-by: axelKingsley <axel.kingsley@gmail.com>
Co-authored-by: Tyler Smith <mail@tcry.pt>

* op-supervisor: dependency-set improvements

Co-authored-by: axelKingsley <axel.kingsley@gmail.com>
Co-authored-by: Tyler Smith <mail@tcry.pt>

---------

Co-authored-by: axelKingsley <axel.kingsley@gmail.com>
Co-authored-by: Tyler Smith <mail@tcry.pt>

…imism#12629)

Update WaitForBlock to maintain two timeouts: a no-change timeout, which fires if the chain's head does not change within a specified window, and an absolute timeout, which fires if the chain's head does not meet or exceed the specified block.

These changes should ideally reduce the number of test flakes we're seeing. Everything takes longer when test executors are under load; by maintaining these two timeouts we can provide longer-running tests with more buffer while retaining the ability to fail fast if the chain gets stuck.

As part of this PR I also refactored the wait method to use polling rather than WebSockets. I've found WebSockets to be unreliable in tests.

* cannon: Remove memory.SetUint32

Remove uint32 word stores from the `mipsevm.memory` interface. `SetUint32` is inflexible
due to its word-alignment constraints. This prevents tests for 32 and 64-bit VMs from
using the same program counter values when writing instructions to memory.

Instead, tests should use the new `testutil.StoreInstruction` utility function to write instructions to any naturally aligned memory location.

* use arch.Word csats in go-ffi

…#12599)

* cannon: Simplify load/stores with helper functions

* use subword utils in MIPS.sol

* lint MIPS.sol

* add natspec to MIPSInstructions.sol

* use updateSubWord in MIPSInstructions.sol

* bump MIPS contract semver

* fix nits

…hereum-optimism#12630)

* feat(ct): add semgrep rule to use encodeCall

encodeCall is almost always better than encodeWithSelector because
it maintains type safety. Prefer encodeCall unless
encodeWithSelector is actually necessary.

* maint(ct): update contracts to use encodeCall

Updates a number of contracts to use encodeCall instead of
encodeWithSelector where possible.

…-optimism#12628)

* update test folder so that smegrep require and revert checks pass for it

* fix test

* op-supervisor: cross-safe-updates PR squashed

op-supervisor: experimental cross-safety, with hazard detection

tweak: Add some errors/error returns in backend/cross.

wip: Chain index <> ID mapping.

fix: Check parent instead of re-checking hazardBlock.

Remove Hazard Work

Write missing DB Bindings OpenBlock, LocallyDerivedFrom, CrossDerivedFrom

Configurable WorkFn for Workers

op-supervisor: move chain-index <> chain ID translation into dependency set, fix some interfaces

op-supervisor: update cross-safety worker routine

op-supervisor: update more error handling

op-supervisor: move errors to types package

op-supervisor: check CanExecuteAt and CanInitiateAt

op-supervisor: determine cross-safe candidate and L1 scope, and more fixes

todo L1 scope increment

op-supervisor: cross-safe L1 scope bump

op-supervisor: dependency set getter

op-supervisor: L1 scope increment fix

op-supervisor: fix cross-safe updates typing

op-node: signal L1 traversal of derivation to supervisor

op-supervisor: fromda fixes and tests

op-supervisor: fix OpenBlock, fix/add missing interface methods, hook up cross-safe worker routines

OpenBlock to return map[uint32]ExecutingMessage

Add Frontier Unit Tests

fix WithParent panic

op-node: register L1 traversal with op-supervisor

op-node,op-supervisor: add logging, temp work around for interop local-safe updates

Add safe_start_test, unsafe_start_test

Add safe_update_test and unsafe_update_test

add worker_test

op-supervisor: fix cross-safe L1 scope bumping

op-supervisor: fix logs DB test

Co-authored-by: axelKingsley <axel.kingsley@gmail.com>
Co-authored-by: Tyler Smith <mail@tcry.pt>

* op-node: fix interop deriver test

* op-e2e: fix interop action test

* op-supervisor: improve map init

* op-node: link interop TODO comment to issue, in engine events emitter

* op-supervisor: cleanup Worker instances of tests

---------

Co-authored-by: axelKingsley <axel.kingsley@gmail.com>
Co-authored-by: Tyler Smith <mail@tcry.pt>

* add interfaces for safe contracts, use named imports for DeputyGuardianModule

* fix failing test

Removes the FeeVaultWithdrawal.s.sol script that was previously
used to trigger withdrawals manually. All of this is automated now
and you can just use Etherscan if you really want to do things
manually so the value of the script is minimal.

* fix failing interfaces

* fix crossl2inbox, revert some changes

* fix semgrep error

…sm#12654)

Bumps [github.com/minio/minio-go/v7](https://github.com/minio/minio-go) from 7.0.78 to 7.0.79.
- [Release notes](https://github.com/minio/minio-go/releases)
- [Commits](minio/minio-go@v7.0.78...v7.0.79)

---
updated-dependencies:
- dependency-name: github.com/minio/minio-go/v7
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…sm#12625)

Replaces the golang package for natspec/semver matching with a
semgrep rule. Code reduction is good.

* op-deployer: Add Docker builds

* fix job syntax

* specify dockerfile

* remove accidental whitespace changes

* use deploy utils over new* in tests

* replace new * with use of deployUtils

* fix failing test

* use deployutils for weth98 test file

* fix semgrep

* fixes

* fixes

* fixes...

This change deletes bad blocks at migration time, since we don't need
to keep historical bad blocks and if not transformed like the other migrated
blocks can lead to panics when trying to load them (which happens when
a new bad block is discovered).

I've tested this locally, by taking a datdir where bad blocks could be
retrieved via `geth db get 0x496e76616c6964426c6f636b` and migrated
it and verified that then the bad blocks cannot be retrieved which looks like this:

INFO [10-28|13:00:32.736] Get operation failed   error="leveldb: not found"

Since the key is not present.

Closes celo-org/celo-blockchain-planning#629

Changes in implementation require changes in version. This is ensured
by `./scripts/checks/check-semver-diff.sh`.

…254)

* OptimismPortal2 set initial `_balance` through StorageSetter pattern

Fixes #239

The custom gas-token feature adaptation for the fault-proof system using
the `OptimismPortal2` contract has been merged recently upstream.

We are using the custom-gas-token feature and additionally require a
modification of the OptimismPortal's `_balance` value to be set
to the entire allocation of Celo on the L2 - meaning that all L1 token is
initially locked in the bridge and only usable on the L2.

Those changes are now adapted also to the `OptimismPortal2`, which
was a requirement to make our custom-gas-token pre-locked balance
feature work in conjunction with fault-proofs.

* Adapt withdraw e2e-tests to work with fault-proofs

* Use prettier for formatting e2e tests

* Fix typo

Co-authored-by: Valentin Rodygin <20768968+carterqw2@users.noreply.github.com>

* Set L1-fee scalars to zero in devnet

---------

Co-authored-by: Valentin Rodygin <20768968+carterqw2@users.noreply.github.com>

)

#274

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278

…ListWithMedian (#277)

* Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test

* Format test/libraries/SafeCall.t.sol

This image resembles Optimism's self hosted CI runner.

Add parallel command to ci-builder

Test new runner image

Install parallel in ci image

Not sure if this is necessary, but building the snapshots asked me to do
it.

Those have warnings with `scripts/checks/interfaces`. Ignore those warnings
for now.

It fails with
ERROR: failed to solve: ghcr.io/anton-rs/kona/kona-fpp-asterisc:kona-client-v0.1.0-alpha.7: failed to resolve source metadata for ghcr.io/anton-rs/kona/kona-fpp-asterisc:kona-client-v0.1.0-alpha.7: failed to authorize: failed to fetch anonymous token: unexpected status from GET request to https://ghcr.io/token?scope=repository%3Aanton-rs%2Fkona%2Fkona-fpp-asterisc%3Apull&service=ghcr.io: 403 Forbidden
and I don't see how I could fix that.

We can't reach the Optimism-internal one in our CI.