Skip to content

e2e: use --broadcast with forge create#281

Merged
karlb merged 1 commit intocelo10from
karlb/fix-forge-create
Dec 9, 2024
Merged

e2e: use --broadcast with forge create#281
karlb merged 1 commit intocelo10from
karlb/fix-forge-create

Conversation

@karlb
Copy link
Copy Markdown

@karlb karlb commented Dec 6, 2024

Forge started to require the --broadcast flag for actually deploying a contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase to the latest upstream, since there have been changes to the overall setup.

Closes #278

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
@karlb karlb marked this pull request as ready for review December 6, 2024 14:31
@karlb karlb merged commit 4bd372a into celo10 Dec 9, 2024
@karlb karlb deleted the karlb/fix-forge-create branch December 9, 2024 10:53
karlb added a commit that referenced this pull request Jan 13, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
karlb added a commit that referenced this pull request Jan 15, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
karlb added a commit that referenced this pull request Jan 15, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
karlb added a commit that referenced this pull request Jan 20, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
karlb added a commit that referenced this pull request Jan 27, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
karlb added a commit that referenced this pull request Jan 29, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
karlb added a commit that referenced this pull request Jan 29, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
karlb added a commit that referenced this pull request Jan 31, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
karlb added a commit that referenced this pull request Feb 4, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
karlb added a commit that referenced this pull request Feb 4, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
karlb added a commit that referenced this pull request Feb 12, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
karlb added a commit that referenced this pull request Feb 12, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
karlb added a commit that referenced this pull request Feb 12, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
piersy pushed a commit that referenced this pull request May 7, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
piersy pushed a commit that referenced this pull request May 8, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
piersy pushed a commit that referenced this pull request May 8, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
piersy pushed a commit that referenced this pull request May 8, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
piersy pushed a commit that referenced this pull request May 20, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
piersy pushed a commit that referenced this pull request May 22, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
Kourin1996 pushed a commit that referenced this pull request Jul 23, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
Kourin1996 pushed a commit that referenced this pull request Jul 25, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
Kourin1996 pushed a commit that referenced this pull request Jul 26, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
Kourin1996 pushed a commit that referenced this pull request Jul 26, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
Kourin1996 pushed a commit that referenced this pull request Jul 27, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
Kourin1996 pushed a commit that referenced this pull request Jul 27, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
Kourin1996 pushed a commit that referenced this pull request Jul 28, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
Kourin1996 pushed a commit that referenced this pull request Jul 28, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
Kourin1996 pushed a commit that referenced this pull request Aug 4, 2025
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
Kourin1996 pushed a commit that referenced this pull request Aug 6, 2025
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
Kourin1996 pushed a commit that referenced this pull request Aug 7, 2025
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
Kourin1996 pushed a commit that referenced this pull request Aug 8, 2025
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
Kourin1996 pushed a commit that referenced this pull request Aug 8, 2025
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
Kourin1996 pushed a commit that referenced this pull request Aug 8, 2025
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
Kourin1996 pushed a commit that referenced this pull request Aug 11, 2025
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
Kourin1996 pushed a commit that referenced this pull request Aug 11, 2025
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
gastonponti pushed a commit that referenced this pull request Sep 22, 2025
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
gastonponti pushed a commit that referenced this pull request Sep 22, 2025
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
gastonponti pushed a commit that referenced this pull request Sep 23, 2025
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
gastonponti pushed a commit that referenced this pull request Jan 8, 2026
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
piersy pushed a commit that referenced this pull request Jan 20, 2026
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
piersy pushed a commit that referenced this pull request Jan 21, 2026
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
piersy pushed a commit that referenced this pull request Jan 22, 2026
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
piersy pushed a commit that referenced this pull request Jan 22, 2026
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
piersy pushed a commit that referenced this pull request Jan 23, 2026
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
piersy pushed a commit that referenced this pull request Feb 5, 2026
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
piersy pushed a commit that referenced this pull request Feb 5, 2026
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
piersy pushed a commit that referenced this pull request Feb 18, 2026
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
karlb pushed a commit that referenced this pull request Mar 3, 2026
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
karlb pushed a commit that referenced this pull request Mar 4, 2026
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
karlb pushed a commit that referenced this pull request Mar 6, 2026
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
karlb pushed a commit that referenced this pull request Mar 9, 2026
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
karlb pushed a commit that referenced this pull request Mar 10, 2026
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
karlb pushed a commit that referenced this pull request Mar 10, 2026
This uses the default fee-currency-directory address from op-geth.
It will fix the issue that the EVM calls into the directoy will fail
when executed on the local devnet.

e2e: use `--broadcast` with `forge create` (#281)

Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

e2e: Failure while deploying token

2 participants