feat(ct): add semgrep rule to use encodeCall#12626
Merged
smartcontracts merged 2 commits intodevelopfrom Oct 25, 2024
Merged
Conversation
encodeCall is almost always better than encodeWithSelector because it maintains type safety. Prefer encodeCall unless encodeWithSelector is actually necessary.
Updates a number of contracts to use encodeCall instead of encodeWithSelector where possible.
Inphi
approved these changes
Oct 24, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* feat(ct): add semgrep rule to use encodeCall encodeCall is almost always better than encodeWithSelector because it maintains type safety. Prefer encodeCall unless encodeWithSelector is actually necessary. * maint(ct): update contracts to use encodeCall Updates a number of contracts to use encodeCall instead of encodeWithSelector where possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
encodeCall is almost always better than encodeWithSelector because
it maintains type safety. Prefer encodeCall unless
encodeWithSelector is actually necessary.