Skip to content

op-program: Compile op-program for Cannon64#12574

Merged
mbaxter merged 2 commits intoethereum-optimism:developfrom
mbaxter:cannon64/build-op-program-for-cannon64
Oct 24, 2024
Merged

op-program: Compile op-program for Cannon64#12574
mbaxter merged 2 commits intoethereum-optimism:developfrom
mbaxter:cannon64/build-op-program-for-cannon64

Conversation

@mbaxter
Copy link
Copy Markdown
Contributor

@mbaxter mbaxter commented Oct 22, 2024

Description
Update reproducible-prestate and op-program-client-mips tasks to include 64-bit MTCannon targets.

Also:

  • Make a few modifications to Dockerfile.repro:
    • Don't make and then copy op-program back to the host
    • Generate meta files and copy them back to the host

@mbaxter mbaxter requested a review from Inphi October 22, 2024 18:53
@mbaxter mbaxter marked this pull request as ready for review October 22, 2024 18:53
Copy link
Copy Markdown
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good. But we should avoid checking the 64-bit prestate for reproducibility.

@mbaxter mbaxter added this pull request to the merge queue Oct 24, 2024
Merged via the queue into ethereum-optimism:develop with commit 21527c6 Oct 24, 2024
@mbaxter mbaxter deleted the cannon64/build-op-program-for-cannon64 branch October 24, 2024 15:20
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
* op-program: Compile op-program for Cannon64

* op-program: Update comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants