Skip to content

Delete bad blocks during migration#267

Merged
piersy merged 1 commit intocelo10from
piersy/migration-delete-bad-blocks
Oct 28, 2024
Merged

Delete bad blocks during migration#267
piersy merged 1 commit intocelo10from
piersy/migration-delete-bad-blocks

Conversation

@piersy
Copy link
Copy Markdown

@piersy piersy commented Oct 28, 2024

This change deletes bad blocks at migration time, since we don't need
to keep historical bad blocks and if not transformed like the other migrated
blocks can lead to panics when trying to load them (which happens when
a new bad block is discovered).

I've tested this locally, by taking a datdir where bad blocks could be
retrieved via geth db get 0x496e76616c6964426c6f636b and migrated
it and verified that then the bad blocks cannot be retrieved which looks like this.

INFO [10-28|13:00:32.736] Get operation failed                     error="leveldb: not found"

Since the key is not present.

@piersy piersy requested review from alecps and karlb October 28, 2024 13:19
@piersy piersy merged commit b9db909 into celo10 Oct 28, 2024
@piersy piersy deleted the piersy/migration-delete-bad-blocks branch October 28, 2024 21:31
gastonponti pushed a commit that referenced this pull request Dec 17, 2024
This change deletes bad blocks at migration time, since we don't need
to keep historical bad blocks and if not transformed like the other migrated
blocks can lead to panics when trying to load them (which happens when
a new bad block is discovered).

I've tested this locally, by taking a datdir where bad blocks could be
retrieved via `geth db get 0x496e76616c6964426c6f636b` and migrated
it and verified that then the bad blocks cannot be retrieved which looks like this:

INFO [10-28|13:00:32.736] Get operation failed   error="leveldb: not found"

Since the key is not present.
karlb pushed a commit that referenced this pull request Jan 13, 2025
This change deletes bad blocks at migration time, since we don't need
to keep historical bad blocks and if not transformed like the other migrated
blocks can lead to panics when trying to load them (which happens when
a new bad block is discovered).

I've tested this locally, by taking a datdir where bad blocks could be
retrieved via `geth db get 0x496e76616c6964426c6f636b` and migrated
it and verified that then the bad blocks cannot be retrieved which looks like this:

INFO [10-28|13:00:32.736] Get operation failed   error="leveldb: not found"

Since the key is not present.
karlb pushed a commit that referenced this pull request Jan 15, 2025
This change deletes bad blocks at migration time, since we don't need
to keep historical bad blocks and if not transformed like the other migrated
blocks can lead to panics when trying to load them (which happens when
a new bad block is discovered).

I've tested this locally, by taking a datdir where bad blocks could be
retrieved via `geth db get 0x496e76616c6964426c6f636b` and migrated
it and verified that then the bad blocks cannot be retrieved which looks like this:

INFO [10-28|13:00:32.736] Get operation failed   error="leveldb: not found"

Since the key is not present.
karlb pushed a commit that referenced this pull request Jan 15, 2025
This change deletes bad blocks at migration time, since we don't need
to keep historical bad blocks and if not transformed like the other migrated
blocks can lead to panics when trying to load them (which happens when
a new bad block is discovered).

I've tested this locally, by taking a datdir where bad blocks could be
retrieved via `geth db get 0x496e76616c6964426c6f636b` and migrated
it and verified that then the bad blocks cannot be retrieved which looks like this:

INFO [10-28|13:00:32.736] Get operation failed   error="leveldb: not found"

Since the key is not present.
karlb pushed a commit that referenced this pull request Jan 20, 2025
This change deletes bad blocks at migration time, since we don't need
to keep historical bad blocks and if not transformed like the other migrated
blocks can lead to panics when trying to load them (which happens when
a new bad block is discovered).

I've tested this locally, by taking a datdir where bad blocks could be
retrieved via `geth db get 0x496e76616c6964426c6f636b` and migrated
it and verified that then the bad blocks cannot be retrieved which looks like this:

INFO [10-28|13:00:32.736] Get operation failed   error="leveldb: not found"

Since the key is not present.
karlb pushed a commit that referenced this pull request Jan 27, 2025
This change deletes bad blocks at migration time, since we don't need
to keep historical bad blocks and if not transformed like the other migrated
blocks can lead to panics when trying to load them (which happens when
a new bad block is discovered).

I've tested this locally, by taking a datdir where bad blocks could be
retrieved via `geth db get 0x496e76616c6964426c6f636b` and migrated
it and verified that then the bad blocks cannot be retrieved which looks like this:

INFO [10-28|13:00:32.736] Get operation failed   error="leveldb: not found"

Since the key is not present.
karlb pushed a commit that referenced this pull request Jan 29, 2025
This change deletes bad blocks at migration time, since we don't need
to keep historical bad blocks and if not transformed like the other migrated
blocks can lead to panics when trying to load them (which happens when
a new bad block is discovered).

I've tested this locally, by taking a datdir where bad blocks could be
retrieved via `geth db get 0x496e76616c6964426c6f636b` and migrated
it and verified that then the bad blocks cannot be retrieved which looks like this:

INFO [10-28|13:00:32.736] Get operation failed   error="leveldb: not found"

Since the key is not present.
karlb pushed a commit that referenced this pull request Jan 29, 2025
This change deletes bad blocks at migration time, since we don't need
to keep historical bad blocks and if not transformed like the other migrated
blocks can lead to panics when trying to load them (which happens when
a new bad block is discovered).

I've tested this locally, by taking a datdir where bad blocks could be
retrieved via `geth db get 0x496e76616c6964426c6f636b` and migrated
it and verified that then the bad blocks cannot be retrieved which looks like this:

INFO [10-28|13:00:32.736] Get operation failed   error="leveldb: not found"

Since the key is not present.
karlb pushed a commit that referenced this pull request Jan 31, 2025
This change deletes bad blocks at migration time, since we don't need
to keep historical bad blocks and if not transformed like the other migrated
blocks can lead to panics when trying to load them (which happens when
a new bad block is discovered).

I've tested this locally, by taking a datdir where bad blocks could be
retrieved via `geth db get 0x496e76616c6964426c6f636b` and migrated
it and verified that then the bad blocks cannot be retrieved which looks like this:

INFO [10-28|13:00:32.736] Get operation failed   error="leveldb: not found"

Since the key is not present.
karlb pushed a commit that referenced this pull request Feb 4, 2025
This change deletes bad blocks at migration time, since we don't need
to keep historical bad blocks and if not transformed like the other migrated
blocks can lead to panics when trying to load them (which happens when
a new bad block is discovered).

I've tested this locally, by taking a datdir where bad blocks could be
retrieved via `geth db get 0x496e76616c6964426c6f636b` and migrated
it and verified that then the bad blocks cannot be retrieved which looks like this:

INFO [10-28|13:00:32.736] Get operation failed   error="leveldb: not found"

Since the key is not present.
karlb pushed a commit that referenced this pull request Feb 4, 2025
This change deletes bad blocks at migration time, since we don't need
to keep historical bad blocks and if not transformed like the other migrated
blocks can lead to panics when trying to load them (which happens when
a new bad block is discovered).

I've tested this locally, by taking a datdir where bad blocks could be
retrieved via `geth db get 0x496e76616c6964426c6f636b` and migrated
it and verified that then the bad blocks cannot be retrieved which looks like this:

INFO [10-28|13:00:32.736] Get operation failed   error="leveldb: not found"

Since the key is not present.
karlb pushed a commit that referenced this pull request Feb 12, 2025
This change deletes bad blocks at migration time, since we don't need
to keep historical bad blocks and if not transformed like the other migrated
blocks can lead to panics when trying to load them (which happens when
a new bad block is discovered).

I've tested this locally, by taking a datdir where bad blocks could be
retrieved via `geth db get 0x496e76616c6964426c6f636b` and migrated
it and verified that then the bad blocks cannot be retrieved which looks like this:

INFO [10-28|13:00:32.736] Get operation failed   error="leveldb: not found"

Since the key is not present.
karlb pushed a commit that referenced this pull request Feb 12, 2025
This change deletes bad blocks at migration time, since we don't need
to keep historical bad blocks and if not transformed like the other migrated
blocks can lead to panics when trying to load them (which happens when
a new bad block is discovered).

I've tested this locally, by taking a datdir where bad blocks could be
retrieved via `geth db get 0x496e76616c6964426c6f636b` and migrated
it and verified that then the bad blocks cannot be retrieved which looks like this:

INFO [10-28|13:00:32.736] Get operation failed   error="leveldb: not found"

Since the key is not present.
karlb pushed a commit that referenced this pull request Feb 12, 2025
This change deletes bad blocks at migration time, since we don't need
to keep historical bad blocks and if not transformed like the other migrated
blocks can lead to panics when trying to load them (which happens when
a new bad block is discovered).

I've tested this locally, by taking a datdir where bad blocks could be
retrieved via `geth db get 0x496e76616c6964426c6f636b` and migrated
it and verified that then the bad blocks cannot be retrieved which looks like this:

INFO [10-28|13:00:32.736] Get operation failed   error="leveldb: not found"

Since the key is not present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants