Skip to content

fix(ci): apply return arg fmt rule to tests#12546

Merged
smartcontracts merged 1 commit intodevelopfrom
sc/ci-semgrep-return-arg-fmt-tests
Oct 23, 2024
Merged

fix(ci): apply return arg fmt rule to tests#12546
smartcontracts merged 1 commit intodevelopfrom
sc/ci-semgrep-return-arg-fmt-tests

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

Applies the semgrep rule for return-arg-fmt to Solidity tests.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.86%. Comparing base (5ecd2db) to head (2b07a47).
Report is 14 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #12546   +/-   ##
========================================
  Coverage    64.86%   64.86%           
========================================
  Files           54       54           
  Lines         4460     4460           
========================================
  Hits          2893     2893           
  Misses        1391     1391           
  Partials       176      176           
Flag Coverage Δ
cannon-go-tests 64.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@smartcontracts smartcontracts force-pushed the sc/ci-semgrep-return-arg-fmt-tests branch from ad1fe42 to 19cd22d Compare October 21, 2024 12:27
Applies the semgrep rule for return-arg-fmt to Solidity tests.
@smartcontracts smartcontracts force-pushed the sc/ci-semgrep-return-arg-fmt-tests branch from 19cd22d to 2b07a47 Compare October 23, 2024 07:28
@AmadiMichael
Copy link
Copy Markdown
Contributor

LGTM!
Any reason we are excluding packages/contracts-bedrock/test/safe-tools from semgrep rules? Can't we apply the changes there too?

@smartcontracts smartcontracts added this pull request to the merge queue Oct 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2024
@smartcontracts smartcontracts added this pull request to the merge queue Oct 23, 2024
Merged via the queue into develop with commit 433f488 Oct 23, 2024
@smartcontracts smartcontracts deleted the sc/ci-semgrep-return-arg-fmt-tests branch October 23, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants