Skip to content

sequencer: Use higher sequencer drift for Celo#251

Merged
piersy merged 1 commit intocelo9from
karlb/seq-drift
Oct 7, 2024
Merged

sequencer: Use higher sequencer drift for Celo#251
piersy merged 1 commit intocelo9from
karlb/seq-drift

Conversation

@karlb
Copy link
Copy Markdown

@karlb karlb commented Oct 7, 2024 •
edited
Loading

@karlb karlb marked this pull request as ready for review October 7, 2024 11:14
piersy
piersy reviewed Oct 7, 2024
View reviewed changes
op-node/rollup/chain_spec.go
Comment on lines +30 to +34
// Normal OP chains wait for five confirmations while Celo waits for finalization, which can take
// up to 3 * 32 blocks. So we should allow for more drift to compensate.
// 3 * 32 - 5 = 91 blocks
// 91 * 12s block time = 1092
const maxSequencerDriftCelo = maxSequencerDriftFjord + 1092
Copy link
Copy Markdown

@piersy piersy Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im a bit confused about the logic here.

The op calculation seems like it took the 5 block times = 60s and then multiplied by a factor of 30 to reach 1800. So for us that would be 33212*30 = 34560.

Copy link
Copy Markdown
Author

@karlb karlb Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question is, "do you really want the buffer to be a multiple of the minimum required drift?". I don't think so, but it really depends on unprovable assumptions. See also https://github.com/celo-org/celo-blockchain-planning/issues/629#issuecomment-2396351090 .

Copy link
Copy Markdown

@piersy piersy Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok makes sense, I guess we just don't know how it was calculated, but yes almost 10 hours (34560s) does seem like an excessive time.

@piersy piersy merged commit d3e06af into celo9 Oct 7, 2024
@piersy piersy deleted the karlb/seq-drift branch October 7, 2024 13:01
@karlb karlb mentioned this pull request Oct 7, 2024
Closed
2 tasks
karlb added a commit that referenced this pull request Oct 12, 2024
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
ebfa901 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Oct 14, 2024
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
41dc620 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Oct 14, 2024
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
72b1f22 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Oct 14, 2024
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
cae92de 
Closes celo-org/celo-blockchain-planning#629
alecps pushed a commit that referenced this pull request Oct 15, 2024
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
4c073ab 
Closes celo-org/celo-blockchain-planning#629
alecps pushed a commit that referenced this pull request Oct 16, 2024
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
7672c9d 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Oct 16, 2024
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
57b4b18 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Jan 13, 2025
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
071be57 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Jan 15, 2025
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
1565c0e 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Jan 15, 2025
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
3e0dcf0 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Jan 20, 2025
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
ff4dbf5 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Jan 27, 2025
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
3cfd374 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Jan 29, 2025
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
f170da5 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Jan 29, 2025
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
769ff8a 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Jan 31, 2025
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
0249acf 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Feb 4, 2025
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
83a27a0 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Feb 4, 2025
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
1f1196f 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Feb 12, 2025
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
31f2edc 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Feb 12, 2025
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
345dba4 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Feb 12, 2025
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
72672ea 
Closes celo-org/celo-blockchain-planning#629
piersy pushed a commit that referenced this pull request May 7, 2025
@karlb @piersy
sequencer: Use higher sequencer drift for Celo (#251)
45938ba 
Closes celo-org/celo-blockchain-planning#629
piersy pushed a commit that referenced this pull request May 8, 2025
@karlb @piersy
sequencer: Use higher sequencer drift for Celo (#251)
0139cc2 
Closes celo-org/celo-blockchain-planning#629
Kourin1996 pushed a commit that referenced this pull request Jul 26, 2025
@karlb @Kourin1996
sequencer: Use higher sequencer drift for Celo (#251)
7bc1057 
Closes https://github.com/celo-org/celo-blockchain-planning/issues/629
Kourin1996 pushed a commit that referenced this pull request Jul 26, 2025
@karlb @Kourin1996
sequencer: Use higher sequencer drift for Celo (#251)
4370149 
Closes https://github.com/celo-org/celo-blockchain-planning/issues/629
Kourin1996 pushed a commit that referenced this pull request Jul 27, 2025
@karlb @Kourin1996
sequencer: Use higher sequencer drift for Celo (#251)
1ce004b 
Closes https://github.com/celo-org/celo-blockchain-planning/issues/629
Kourin1996 pushed a commit that referenced this pull request Jul 27, 2025
@karlb @Kourin1996
sequencer: Use higher sequencer drift for Celo (#251)
fe44637 
Closes https://github.com/celo-org/celo-blockchain-planning/issues/629
Kourin1996 pushed a commit that referenced this pull request Jul 28, 2025
@karlb @Kourin1996
sequencer: Use higher sequencer drift for Celo (#251)
ef6a926 
Closes https://github.com/celo-org/celo-blockchain-planning/issues/629
Kourin1996 pushed a commit that referenced this pull request Jul 28, 2025
@karlb @Kourin1996
sequencer: Use higher sequencer drift for Celo (#251)
dd9d0b4 
Closes https://github.com/celo-org/celo-blockchain-planning/issues/629
Kourin1996 pushed a commit that referenced this pull request Aug 4, 2025
@karlb @Kourin1996
sequencer: Use higher sequencer drift for Celo (#251)
eb374d3 
Closes https://github.com/celo-org/celo-blockchain-planning/issues/629
Kourin1996 pushed a commit that referenced this pull request Aug 6, 2025
@karlb @Kourin1996
sequencer: Use higher sequencer drift for Celo (#251)
65076b6 
Closes https://github.com/celo-org/celo-blockchain-planning/issues/629
Kourin1996 pushed a commit that referenced this pull request Aug 7, 2025
@karlb @Kourin1996
sequencer: Use higher sequencer drift for Celo (#251)
1610706 
Closes https://github.com/celo-org/celo-blockchain-planning/issues/629
Kourin1996 pushed a commit that referenced this pull request Aug 8, 2025
@karlb @Kourin1996
sequencer: Use higher sequencer drift for Celo (#251)
1da8a6b 
Closes https://github.com/celo-org/celo-blockchain-planning/issues/629
Kourin1996 pushed a commit that referenced this pull request Aug 8, 2025
@karlb @Kourin1996
sequencer: Use higher sequencer drift for Celo (#251)
206a1bc 
Closes https://github.com/celo-org/celo-blockchain-planning/issues/629
Kourin1996 pushed a commit that referenced this pull request Aug 11, 2025
@karlb @Kourin1996
sequencer: Use higher sequencer drift for Celo (#251)
8202d4f 
Closes https://github.com/celo-org/celo-blockchain-planning/issues/629
Kourin1996 pushed a commit that referenced this pull request Aug 11, 2025
@karlb @Kourin1996
sequencer: Use higher sequencer drift for Celo (#251)
c14a156 
Closes https://github.com/celo-org/celo-blockchain-planning/issues/629
gastonponti pushed a commit that referenced this pull request Sep 22, 2025
@karlb @gastonponti
sequencer: Use higher sequencer drift for Celo (#251)
94510d2 
Closes https://github.com/celo-org/celo-blockchain-planning/issues/629
gastonponti pushed a commit that referenced this pull request Sep 22, 2025
@karlb @gastonponti
sequencer: Use higher sequencer drift for Celo (#251)
6084264 
Closes https://github.com/celo-org/celo-blockchain-planning/issues/629
gastonponti pushed a commit that referenced this pull request Sep 23, 2025
@karlb @gastonponti
sequencer: Use higher sequencer drift for Celo (#251)
326d428 
Closes https://github.com/celo-org/celo-blockchain-planning/issues/629
gastonponti pushed a commit that referenced this pull request Jan 8, 2026
@karlb @gastonponti
sequencer: Use higher sequencer drift for Celo (#251)
c1e9fef 
Closes https://github.com/celo-org/celo-blockchain-planning/issues/629
piersy pushed a commit that referenced this pull request Jan 20, 2026
@karlb @piersy
sequencer: Use higher sequencer drift for Celo (#251)
571d5a8 
Closes celo-org/celo-blockchain-planning#629
piersy pushed a commit that referenced this pull request Jan 22, 2026
@karlb @piersy
sequencer: Use higher sequencer drift for Celo (#251)
97a823e 
Closes celo-org/celo-blockchain-planning#629
piersy pushed a commit that referenced this pull request Jan 22, 2026
@karlb @piersy
sequencer: Use higher sequencer drift for Celo (#251)
7898fb6 
Closes celo-org/celo-blockchain-planning#629
piersy pushed a commit that referenced this pull request Jan 23, 2026
@karlb @piersy
sequencer: Use higher sequencer drift for Celo (#251)
8f24770 
Closes celo-org/celo-blockchain-planning#629
piersy pushed a commit that referenced this pull request Feb 5, 2026
@karlb @piersy
sequencer: Use higher sequencer drift for Celo (#251)
c4a86ab 
Closes celo-org/celo-blockchain-planning#629
piersy pushed a commit that referenced this pull request Feb 5, 2026
@karlb @piersy
sequencer: Use higher sequencer drift for Celo (#251)
bf766f4 
Closes celo-org/celo-blockchain-planning#629
piersy pushed a commit that referenced this pull request Feb 18, 2026
@karlb @piersy
sequencer: Use higher sequencer drift for Celo (#251)
0157815 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Mar 3, 2026
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
f71fcdd 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Mar 4, 2026
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
fcd4f95 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Mar 6, 2026
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
e5d0b36 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Mar 9, 2026
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
3ee0f13 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Mar 10, 2026
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
f0db553 
Closes celo-org/celo-blockchain-planning#629
karlb added a commit that referenced this pull request Mar 10, 2026
@karlb
sequencer: Use higher sequencer drift for Celo (#251)
ac6d969 
Closes celo-org/celo-blockchain-planning#629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piersy piersy piersy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@karlb @piersy