Skip to content

Use PEP 639 license metadata for uv itself#16477

Merged
konstin merged 1 commit intoastral-sh:mainfrom
wagenrace:patch-1
Mar 15, 2026
Merged

Use PEP 639 license metadata for uv itself#16477
konstin merged 1 commit intoastral-sh:mainfrom
wagenrace:patch-1

Conversation

@wagenrace
Copy link
Contributor

@wagenrace wagenrace commented Oct 28, 2025

Summary

In pep 639 the classifier for licenses gets deprecated in favor of the license field.
The benefits for UV:

  • Clear that you can pick a license, not have to have both
  • Clear it is version 2 for the Apache license

https://peps.python.org/pep-0639/

Test Plan

Builds, works.
If the license shows up in pypi.org with the SPDX operator, it works

@zanieb
Copy link
Member

zanieb commented Oct 28, 2025

We've tried updating this before and it broke our release process.

@wagenrace
Copy link
Contributor Author

wagenrace commented Oct 28, 2025

I see the red in the workflows
Is it the pipelines or the older versions of Python?

Might want to look at it but do not want to reinvent to much

@wagenrace
Copy link
Contributor Author

wagenrace commented Oct 28, 2025

The error I see is "Error: failed with: Error: missing API token, please run depot login"
I do not think this is code-related, right?

@zanieb
Copy link
Member

zanieb commented Oct 28, 2025

The Depot / Docker thing is unrelated.

@zanieb
Copy link
Member

zanieb commented Oct 28, 2025

I can't seem to find the failure from the previous attempt. @konstin may remember.

@konstin
Copy link
Member

konstin commented Oct 28, 2025

It's in astral-sh/ruff#19499 and the revert PRs. It should be fixed in maturin now but we should double check so we don't fail at the PyPI upload stage.

@wagenrace
Copy link
Contributor Author

wagenrace commented Oct 28, 2025

Can that be tested without merging?
Uploading to test.pypi.com?

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 15, 2026 •
edited
Loading

Merging this PR will improve performance by 8.03%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 4 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation resolve_warm_jupyter 76.7 ms 71 ms +8.03%

Comparing wagenrace:patch-1 (0b83b57) with main (399094a)

Open in CodSpeed

1 similar comment
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 15, 2026

Merging this PR will improve performance by 8.03%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 4 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation resolve_warm_jupyter 76.7 ms 71 ms +8.03%

Comparing wagenrace:patch-1 (0b83b57) with main (399094a)

Open in CodSpeed

@konstin
Copy link
Member

konstin commented Mar 15, 2026

Since this has been fixed on the maturin side and we're starting to warn about this being a bad practice, we should follow our own advice and merge this.

@konstin konstin enabled auto-merge (squash) March 15, 2026 21:24
@konstin konstin disabled auto-merge March 15, 2026 21:24
@konstin konstin changed the title Update license to pep639 standard Use PEP 639 license metadata for uv itself Mar 15, 2026
@konstin konstin added the enhancement New feature or improvement to existing functionality label Mar 15, 2026
@konstin konstin enabled auto-merge (squash) March 15, 2026 21:25
@konstin konstin mentioned this pull request Mar 15, 2026
Merged
@konstin konstin merged commit f8bd28a into astral-sh:main Mar 15, 2026
69 of 70 checks passed
@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Mar 16, 2026
Merged
@BrewTestBot BrewTestBot mentioned this pull request Mar 17, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or improvement to existing functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wagenrace @zanieb @konstin