Skip to content

fix(cache): accept legacy ID format from pre-0.11.9 cache entries (#19298)#19301

Merged
woodruffw merged 4 commits intoastral-sh:mainfrom
ChrisJr404:fix/cache-legacy-id-deserialize-19298
May 6, 2026
Merged

fix(cache): accept legacy ID format from pre-0.11.9 cache entries (#19298)#19301
woodruffw merged 4 commits intoastral-sh:mainfrom
ChrisJr404:fix/cache-legacy-id-deserialize-19298

Conversation

@ChrisJr404
Copy link
Copy Markdown
Contributor

Summary

Closes #19298.

#19201 (0.11.9) switched revision IDs from 21-character nanoid to uv_fastid's 16-character IDs, but didn't bump the cache bucket version. As a result, when 0.11.9+ opens a cache populated by an older uv, deserialization of an existing revision pointer hard-fails with:

Failed to deserialize cache entry
invalid ID: "HM0NxJml5hc7UjbfTWT1r" (must be 16 ID characters in the alphabet)

This effectively poisons long-lived caches on shared CI workers after upgrade.

Fix

Mirror the existing convention already documented on ArchiveId in crates/uv-cache/src/archive.rs:

/// Note: for compatibility with the existing `archive-v0` bucket, this is a newtype
/// around a `String` instead of a newtype around `uv_fastid::Id`. In the future,
/// we may want to bump to `archive-v1` and switch to using `uv_fastid::Id` directly.

RevisionId had the same shape but was migrated to uv_fastid::Id directly in #19201, which is what made the legacy 21-character pointers undecodable. Switching RevisionId back to String (with the same uv_fastid::insecure() source for new IDs) restores forward-compatibility with both formats. The ID is only used as an opaque path/string component, so no other call site needs to change.

Test plan

  • New unit test in crates/uv-distribution/src/source/revision.rs:
    • deserialize_legacy_nanoid_revision round-trips a Revision with a 21-character legacy ID through rmp_serde (the exact failing path from the bug report)
    • round_trip_current_revision confirms freshly-generated IDs still serialize as the new 16-character form
  • cargo build -p uv clean
  • cargo test -p uv-distribution --lib -> 21/21 passing (incl. the 2 new tests)
  • cargo test -p uv-fastid -> 4/4 passing
  • cargo fmt --check clean
  • cargo clippy -p uv-distribution --lib --tests clean

After astral-sh#19201 switched revision IDs from 21-character `nanoid` to
`uv_fastid`'s 16-character IDs, opening a cache populated by an older
uv version fails with `Failed to deserialize cache entry: invalid ID`,
because `uv_fastid::Id` rejects any string that isn't exactly 16
characters in its alphabet.

Mirror the existing convention from `ArchiveId` (newtype around
`String`) for `RevisionId` so that pointers written by older uv versions
continue to deserialize. New IDs are still generated via
`uv_fastid::insecure()`.

Closes astral-sh#19298.
@woodruffw
Copy link
Copy Markdown
Member

@ChrisJr404 Can you mention the responsible cache bucket in the RevisionID comment, like we have for ArchiveID? I believe in this case it's the SourceDistribution bucket.

…ment

Per @woodruffw — mirror the ArchiveId comment style by naming the
`sdists-v9` bucket and the SourceDistributions cache enum variant, plus
note the same future-bump path.
@ChrisJr404
Copy link
Copy Markdown
Contributor Author

ChrisJr404 commented May 6, 2026

Done, b4b42ff. Pulled the bucket name (sdists-v9) and the SourceDistributions variant into the comment, plus a line saying that if we ever bump to sdists-v10 that would be the spot to move to uv_fastid::Id, since the same path is already noted for archive-v0.

woodruffw added 2 commits May 6, 2026 09:03
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw
Copy link
Copy Markdown
Member

Thanks @ChrisJr404. In the future, please make sure you follow our AI Policy when writing responses on PRs.

@ChrisJr404
Copy link
Copy Markdown
Contributor Author

ChrisJr404 commented May 6, 2026

Got it, will read through the policy. Apologies for missing it.

@woodruffw woodruffw merged commit b80d791 into astral-sh:main May 6, 2026
53 checks passed
@woodruffw
Copy link
Copy Markdown
Member

No problem, thank you for contributing!

@zanieb zanieb added the bug Something isn't working label May 6, 2026
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request May 8, 2026
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [uv](https://github.com/astral-sh/uv) | patch | `0.11.7` → `0.11.11` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (uv)</summary>

### [`v0.11.11`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#01111)

[Compare Source](astral-sh/uv@0.11.10...0.11.11)

Released on 2026-05-06.

##### Bug fixes

- Accept legacy ID format from pre-0.11.9 cache entries ([#&#8203;19301](astral-sh/uv#19301))

### [`v0.11.10`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#01110)

[Compare Source](astral-sh/uv@0.11.9...0.11.10)

Released on 2026-05-05.

##### Bug fixes

- Allow pre-release Python requests with non-zero patch versions ([#&#8203;19286](astral-sh/uv#19286))

### [`v0.11.9`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0119)

[Compare Source](astral-sh/uv@0.11.8...0.11.9)

Released on 2026-05-04.

This release includes a special release candidate for the next Python 3.14 patch release. Python 3.14 included a new garbage collection implementation, which reduced pause times but caused significant unexpected memory pressure in production environments. In 3.14.5 and 3.15, the previous garbage collection implementation will be restored.

We would greatly appreciate if you tested the 3.14.5rc1 version included in this release. The stable version is expected to be released soon and any feedback on potential issues would be helpful to the Python development team.

For more context, see the [announcement](https://discuss.python.org/t/reverting-the-incremental-gc-in-python-3-14-and-3-15/107014), [issue](python/cpython#148726), and [pull request](python/cpython#148720).

Issues with the new release can be reported in the uv or CPython issue trackers.

##### Python

- Upgrade PyPy to v7.3.22
- Add CPython 3.14.5rc1
- On macOS, CPython statically links `libpython` to match Linux

##### Enhancements

- Omit compatible release desugaring for pre-release hints ([#&#8203;19267](astral-sh/uv#19267))
- Fix file locks on Android ([#&#8203;18323](astral-sh/uv#18323))

##### Preview

- `uv audit` add reporting for adverse project statuses ([#&#8203;19128](astral-sh/uv#19128))

##### Bug fixes

- Discover versioned Python executables when `requires-python` pins a version ([#&#8203;18700](astral-sh/uv#18700))
- Fix URL prefix matching to require path boundaries ([#&#8203;19154](astral-sh/uv#19154))
- Fix transitive Git path dependencies in lockfiles ([#&#8203;19269](astral-sh/uv#19269))
- Handle incorrect unlock error in `LockedFile::drop` on Wine ([#&#8203;19229](astral-sh/uv#19229))
- Prevent uninstalling site-packages for empty `top_level.txt` in `.egg-info` ([#&#8203;19114](astral-sh/uv#19114))
- Use symlinks instead of junctions on Wine ([#&#8203;19213](astral-sh/uv#19213))
- Fix floating-point environment handling on ARMv7 ([#&#8203;19157](astral-sh/uv#19157))
- Redact credentials from remote requirements URL in offline errors ([#&#8203;19216](astral-sh/uv#19216))
- Windows tramplolines no longer set `PYTHONHOME` and only set `__PYVENV_LAUNCHER__` for virtual environments ([#&#8203;19199](astral-sh/uv#19199))

##### Documentation

- Mark `--native-tls` and `UV_NATIVE_TLS` as deprecated ([#&#8203;18705](astral-sh/uv#18705))
- Re-add `pytorch-triton-rocm` to PyTorch ROCm docs ([#&#8203;19241](astral-sh/uv#19241))
- Tweak changelog entries for 0.11.8 ([#&#8203;19188](astral-sh/uv#19188))
- Add 'Exporting lockfiles' to the Concepts->Projects index ([#&#8203;19209](astral-sh/uv#19209))
- Clarify that `uv init` creates git files / folders in the projects guide ([#&#8203;19183](astral-sh/uv#19183))

### [`v0.11.8`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0118)

[Compare Source](astral-sh/uv@0.11.7...0.11.8)

Released on 2026-04-27.

##### Enhancements

- Add `--python-downloads-json-url` to `python pin` ([#&#8203;19092](astral-sh/uv#19092))
- Fetch uv from Astral mirror during self-update ([#&#8203;18682](astral-sh/uv#18682))
- Support `pip uninstall -y` ([#&#8203;19082](astral-sh/uv#19082))
- Allow `exclude-newer` to be missing from the lockfile when `exclude-newer-span` is present ([#&#8203;19024](astral-sh/uv#19024))
- Only show the version number in `uv self version --short` ([#&#8203;19019](astral-sh/uv#19019))
- Silence warnings on empty `SSL_CERT_DIR` directory ([#&#8203;19018](astral-sh/uv#19018))
- Use a sentinel timestamp for relative `exclude-newer` and `exclude-newer-package` values in lockfiles ([#&#8203;19022](astral-sh/uv#19022), [#&#8203;19101](astral-sh/uv#19101))

##### Configuration

- Add `UV_PYTHON_NO_REGISTRY` ([#&#8203;19035](astral-sh/uv#19035))
- Add an environment variable for `UV_NO_PROJECT` ([#&#8203;19052](astral-sh/uv#19052))
- Expose `UV_PYTHON_SEARCH_PATH` for Python discovery `PATH` overrides ([#&#8203;19034](astral-sh/uv#19034))

##### Bug fixes

- Add `rust-toolchain.toml` to uv-build sdist ([#&#8203;19131](astral-sh/uv#19131))
- Ensure uv invocations of git do not inherit repository location environment variables ([#&#8203;19088](astral-sh/uv#19088))
- Redact pre-signed upload URLs in verbose output ([#&#8203;19146](astral-sh/uv#19146))
- Handle transitive URL dependencies in PEP 517 build requirements ([#&#8203;19076](astral-sh/uv#19076), [#&#8203;19086](astral-sh/uv#19086))
- Support `uv lock` on a `pyproject.toml` that only contains dependency-groups ([#&#8203;19087](astral-sh/uv#19087))
- Disable transparent Python upgrades in projects when a patch version is requested via `.python-version` ([#&#8203;19102](astral-sh/uv#19102))
- Fix Python variant tagging in the Windows registry ([#&#8203;19012](astral-sh/uv#19012))
- Ban external symlinks in `.tar.zst` wheels ([#&#8203;19144](astral-sh/uv#19144))

##### Distributions

- Remove deprecated license classifiers from uv-build and add Python 3.14 classifier ([#&#8203;19130](astral-sh/uv#19130))

##### Documentation

- Bump astral-sh/setup-uv version in docs ([#&#8203;19030](astral-sh/uv#19030))
- Update PyTorch documentation for PyTorch 2.11 ([#&#8203;19095](astral-sh/uv#19095))

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNjguNSIsInVwZGF0ZWRJblZlciI6IjQzLjE2OC41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6cGF0Y2giXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in 0.11.9: Failed to deserialize cache entry: invalid ID for IDs written by older uv versions

3 participants