Treat 'Dynamic' values as case-insensitive#18669
Merged
charliermarsh merged 1 commit intomainfrom Mar 23, 2026
Merged
Conversation
woodruffw
approved these changes
Mar 23, 2026
septatrix
reviewed
Mar 23, 2026
| "Provides-Extra" => return Err(MetadataError::DynamicField("Provides-Extra")), | ||
| "Version" => dynamic = true, | ||
| _ => (), | ||
| let field = field.as_str(); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
konstin
approved these changes
Mar 23, 2026
Member
konstin
left a comment
There was a problem hiding this comment.
In the absence of a precise definition, the practical standard is set by what the standard library email.parser module can parse using the compat32 policy.
Yeah let's go with what packaging does.
zanieb
pushed a commit
that referenced
this pull request
Mar 24, 2026
konstin
pushed a commit
that referenced
this pull request
Mar 24, 2026
## Summary Follows the convention used by, e.g., [`packaging`](https://github.com/pypa/packaging/blob/2f933f2a60e7b84d503b84a1713a8d112cfe49c1/src/packaging/metadata.py#L647-L657). Closes #18667.
konstin
pushed a commit
that referenced
this pull request
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows the convention used by, e.g.,
packaging.Closes #18667.