Enable checksum verification in the generated installer script#18625
Merged
Enable checksum verification in the generated installer script#18625
Conversation
f952c56 to
2e2691f
Compare
Gankra
approved these changes
Mar 23, 2026
Contributor
Gankra
left a comment
There was a problem hiding this comment.
This took me a while to properly get why we need to do this at all, but now it all makes sense (regrettably). Because we're doing fully custom builds, we're also taking over all the hashing, so dist has no idea what's going on.
Member
Author
|
Yes, sorry I should've explained the problem in the PR description not just the solution :) |
konstin
pushed a commit
that referenced
this pull request
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to generate a local dist manifest for the built artifacts, and then pass that into the global artifact builder. cargo-dist will pick up the manifest and merge it into the final manifest, and then embed the checksums into the installer scripts.
This should partially resolve #13074, but Windows installers are still missing the checksum.
Test plan
Run the release workflow in dry-run mode on this branch: https://github.com/astral-sh/uv/actions/runs/23388294448
Then inspect the generated
.shscripts and observe the embedded checksums.