Skip to content

Add riscv64 musl target to build-release-binaries workflow#18228

Merged
konstin merged 5 commits intoastral-sh:mainfrom
messense:patch-1
Mar 10, 2026
Merged

Add riscv64 musl target to build-release-binaries workflow#18228
konstin merged 5 commits intoastral-sh:mainfrom
messense:patch-1

Conversation

@messense
Copy link
Contributor

@messense messense commented Mar 1, 2026 •
edited
Loading

@messense messense changed the title Add riscv64 target to build-release-binaries workflow Add riscv64 musl target to build-release-binaries workflow Mar 1, 2026
@messense messense closed this Mar 1, 2026
@messense messense reopened this Mar 1, 2026
@zanieb zanieb requested a review from konstin March 2, 2026 14:37
@zanieb
Copy link
Member

zanieb commented Mar 2, 2026

Just to confirm, since adding more platforms has bit us before, PyPI will accept this wheel as tagged?

@messense
Copy link
Contributor Author

messense commented Mar 2, 2026

Yes, see https://github.com/pypi/warehouse/blob/481300222f98d96ce587311fd5a791daeccff791/warehouse/forklift/legacy.py#L166-L178

For example we have https://files.pythonhosted.org/packages/63/d6/5b5efe3ca0c043357ed3f8d2b2d556169fdbf1ff75e50e8e597708a359d2/maturin-1.12.6-py3-none-manylinux_2_31_riscv64.musllinux_1_1_riscv64.whl

@konstin
Copy link
Member

konstin commented Mar 6, 2026

I'm updating maturin, then we can do this while keeping the --compatibility pypi: #18342

@zanieb
Copy link
Member

zanieb commented Mar 7, 2026

We should also add this as a tier two platform then

konstin
konstin approved these changes Mar 9, 2026
View reviewed changes
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@konstin
Copy link
Member

konstin commented Mar 9, 2026

We should also add this as a tier two platform then

It is already, due to the GNU build of it.

@konstin
Copy link
Member

konstin commented Mar 9, 2026

Hmm this doesn't work yet:

Caused by: PyPI validation failed: Platform tag 'manylinux2014_riscv64' in wheel 'uv-0.10.9-py3-none-manylinux_2_17_riscv64.manylinux2014_riscv64.musllinux_1_1_riscv64.whl' is not allowed by PyPI

@messense
Copy link
Contributor Author

messense commented Mar 10, 2026

Hmm this doesn't work yet:

Caused by: PyPI validation failed: Platform tag 'manylinux2014_riscv64' in wheel 'uv-0.10.9-py3-none-manylinux_2_17_riscv64.manylinux2014_riscv64.musllinux_1_1_riscv64.whl' is not allowed by PyPI

Fixed, move it to manylinux_2_31 like maturin does. Also fixed the issue on maturin side: PyO3/maturin#3078

@messense messense requested a review from konstin March 10, 2026 00:20
@konstin konstin added the enhancement New feature or improvement to existing functionality label Mar 10, 2026
@konstin
Copy link
Member

konstin commented Mar 10, 2026

Thank you!

@konstin konstin merged commit 91823b6 into astral-sh:main Mar 10, 2026
103 checks passed
@messense messense deleted the patch-1 branch March 10, 2026 15:25
@BrewTestBot BrewTestBot mentioned this pull request Mar 13, 2026
Merged
@zanieb zanieb mentioned this pull request Mar 23, 2026
Merged
zanieb added a commit that referenced this pull request Mar 24, 2026
@zanieb
Add missing riscv64gc-unknown-linux-musl entry to dist-workspace (#…
5ad8577 
…18686)

This looks omitted from #18228 and I
noticed a warning from the new release step from
#18625
konstin pushed a commit that referenced this pull request Mar 24, 2026
@zanieb @konstin
Add missing riscv64gc-unknown-linux-musl entry to dist-workspace (#…
3ce279a 
…18686)

This looks omitted from #18228 and I
noticed a warning from the new release step from
#18625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@konstin konstin konstin approved these changes

Assignees

No one assigned

Labels

enhancement New feature or improvement to existing functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RISC-V64 musllinux binaries

3 participants

@messense @zanieb @konstin