Add support for using Python 3.6 interpreters#18454
Conversation
Merging this PR will degrade performance by 5.65%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | resolve_warm_jupyter |
74.9 ms | 79.4 ms | -5.65% |
Comparing zaniebot:claude/add-python-3.6-support-BsaGJ (da0b202) with main (0507193)
da0b202 to
56965c2
Compare
Lower the minimum supported Python version check from 3.7 to 3.6, allowing uv to discover and use system-installed Python 3.6 interpreters. This is relevant for RHEL 8-style distributions that ship Python 3.6 as their platform-python until 2029. Add CI system tests for Python 3.6 and 3.7 via the deadsnakes PPA to ensure these older versions continue to work.
56965c2 to
e68ba2b
Compare
There was a problem hiding this comment.
Drive-by comment without a full review: IMO it's not useful to check this file in, because it carries a risk of diverging from the actual patches to the .py files. I would simply rely on git history and the README (and maybe rephrase the README to emphasize that these are patched versions of the vendored files) and manually cherry-pick the patch when revendoring.
Alternatively, leave this file in, but don't commit the changes to the .py files in source control, and instead apply this file at build time.
There was a problem hiding this comment.
Hm I'm quite partial to checking it in so it's easy to apply in the future and very clear what changed. I'm pretty hesitant to deal with applying it at build time.
These files rarely change and we're a small team. I think optimizing for strictly preventing drift here is a bit silly.
There was a problem hiding this comment.
I'll write a script to perform the vendoring.
ba45858 to
09e6298
Compare
charliermarsh
left a comment
There was a problem hiding this comment.
I'm comfortable with this change. Do we have a clear guidance for whether it would constitute a breaking change to undo this in the future, given that it's not in our officially supported version list?
|
I would say it is not a breaking change per our policy. I can make that clearer. |
Applies a patch to use Python 3.6 compatible types in our vendored
packagingimplementation used in the interpreter query script. Adds Python 3.6 and 3.7 test coverage in CI.Closes #7418