Conversation
* Store lint report in CI * Include Node.js in Android Docker image used to run unit tests. Node.js is required to run Spotless. * Add step to run 'sdkmanager --list' for debugging * Clean build when creating 'ci' directory in Makefile steps * Use Android 29 x86 system image for functional tests * Fix coverage file location * Specify specific codecov file to upload * Add codecov.yml configuration * Remove duplcate restore/save gradle cache tasks when running functional tests * Try running CI functional tests with Android 33 x86_64 image * Use 'system-images;android-29;default;x86' image for functional-tests. A recent post by CircleCI suggests that higher API levels and/or system images with Google APIs 'have been observed to be less stable'. It is suggested to use a lower system image if failures are reported. * Add comment and fix typo
* Update Gradle settings for :edge module to use Core 2.0 * First pass at updating EdgeExtension for 2.0 * Remove class EdgeExtensionListener * Update EdgeState for Core 2.0 * Add readForEvent and remove event queue in EdgeExtension * Update Edge public APIs to Core 2.0 * Remove unused EventUtils methods * Set execute permission to pre-commit Git Hook * Apply format fixes * Update EdgeProperties for Core 2.0 * Fix log message * Fix uses of Log and StringUtils to get code to compile * Fix retrieval of assurance id to use new shared state and data reader apis * Simplify EventUtils.getEdgeConfiguration * Update version to 2.0.0 and dependent Core and Identity versions to 2.0.0 * Add javadoc for onRegistered * Update :app build.gradle for core 2.0 * Update JavaDoc comments for EdgeSharedStateCallback * Update ImplementationDetails for Core 2.0 * Move public variables above private variables * Set public API timeout to 5 sec to match existing 1.0 timeout * Clarify comment in bootupIfNeeded on use of Hub shared state * Move API timeout variable to constants class * Fix wording in sendEvent log messages * Use public EventSource instead of constant * Rename EdgeSharedStateCallback setSharedState to createSharedState * Cleanup functions used to retrieve configuration and identity shared states * Cleanup EventUtils by using NonNull annotation and using public EventType/EventSource * Rename EdgeExtension method to processAndQueueEvent * Fix wording in comment
* Use event type/source from core * Remove getName, use base string value
* [MOB-17672] Update log usages for 2.x * More log updates Co-authored-by: Kevin Lind <40409666+kevinlind@users.noreply.github.com>
* More logging updates for 2.x - test code * Finaling * More logging and lambdas
* Implement new processHit, fix HitProcessor tests * EdgeDataEntity consolidation * Review impl, fixes
* Implement new processHit, fix HitProcessor tests * EdgeDataEntity consolidation * Migrate unit tests to mockito * Migrate NetworkResponseHandlerTest to mockito * never, never enough * Update EdgePublicAPITests for mockito, use eventType/source from core * Fix EdgeStateTests and add new tests for bootup * Initial setup on EdgeExtensionTest * Update log assertions to verify on the new services Log * just mockitoVersion
* Implement new processHit, fix HitProcessor tests * EdgeDataEntity consolidation * Migrate unit tests to mockito * Migrate NetworkResponseHandlerTest to mockito * never, never enough * Update EdgePublicAPITests for mockito, use eventType/source from core * Fix EdgeStateTests and add new tests for bootup * Initial setup on EdgeExtensionTest * Update log assertions to verify on the new services Log * Update EdgeExtension unit tests, fixes for empty event data handling and data unwrapping * Update set/getLocationHint unit tests * Update unit tests for bootup * Remove MockHitQueue, using mockito * docs on test utility methods
[MOB-17093] Part3 - re-enable functional tests
* Clean-up and DataReader usages * Fix check for identityMap * Increase coverage for RequestBuilder * Format
* Use JSONUtils, StringUtils from core * Revert changes * Clean up the cleanup * Utils cov++
* Update dependencies * Update workflows to java 11
* Close hit queue on Edge extension onUnregistered For restart tests, reset the ServiceProvider to create new instance of DataQueue. Clear database after functional tests. * Reword method comment for FunctionalTestHelper.resetCoreHelper * Rename ServiceProviderHelper resetServiceProvider to resetServices
Codecov Report
@@ Coverage Diff @@
## staging #28 +/- ##
==========================================
Coverage ? 83.17%
Complexity ? 380
==========================================
Files ? 29
Lines ? 1545
Branches ? 219
==========================================
Hits ? 1285
Misses ? 161
Partials ? 99
Flags with carried forward coverage won't be shown. Click here to find out more. |
kevinlind
approved these changes
Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: