Skip to content

[MOB-17672] Update extension API usages for 2.x#5

Merged
kevinlind merged 1 commit intoadobe:dev-v2.0.0from
emdobrin:MOB-17672-fix-deprecations
Dec 9, 2022
Merged

[MOB-17672] Update extension API usages for 2.x#5
kevinlind merged 1 commit intoadobe:dev-v2.0.0from
emdobrin:MOB-17672-fix-deprecations

Conversation

@emdobrin
Copy link
Copy Markdown
Contributor

@emdobrin emdobrin commented Dec 8, 2022

Description

Update other extension API usages to fix deprecation warnings. These changes are primarily in the test classes.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@emdobrin emdobrin requested review from kevinlind December 8, 2022 22:18
@emdobrin emdobrin force-pushed the MOB-17672-fix-deprecations branch from 28ad723 to 578d4be Compare December 8, 2022 23:14
Comment on lines +50 to +53
MobileCore.log(
LoggingMode.ERROR,
LOG_TAG,
"Edge - There was an error registering the Edge extension: " + extensionError.getErrorName()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this log message to the new API?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the next PR

@kevinlind kevinlind merged commit a78de15 into adobe:dev-v2.0.0 Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants