Skip to content

[MOB-17671] Updates for HitProcessing 2.x#8

Merged
kevinlind merged 3 commits intoadobe:dev-v2.0.0from
emdobrin:MOB-17671
Dec 12, 2022
Merged

[MOB-17671] Updates for HitProcessing 2.x#8
kevinlind merged 3 commits intoadobe:dev-v2.0.0from
emdobrin:MOB-17671

Conversation

@emdobrin
Copy link
Copy Markdown
Contributor

Description

  • Adopt new API from HitProcessing 2.x - void processHit(@nonnull final DataEntity dataEntity, @nonnull final HitProcessingResult processingResult)
  • Update EdgeHitProcessor tests for the same, added new helpers in increase tests readability
  • Consolidate EdgeDataEntity + EdgeDataEntitySerializer into one, using simple to/fromDataEntity APIs.
  • RequestBuilder now clones the event data before adding standard xdm fields like timestamp, id

Related Issue

Motivation and Context

How Has This Been Tested?

EdgeDataEntity/EdgeHitProcessor unit tests
Not all the tests pass yet, more updates will come in the following PRs

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Copy Markdown
Contributor

@kevinlind kevinlind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I added a couple minor comments.

@emdobrin emdobrin requested a review from kevinlind December 12, 2022 19:50
@kevinlind kevinlind merged commit d9df44c into adobe:dev-v2.0.0 Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants