Skip to content

Fix network request await for asserts#16

Merged
kevinlind merged 1 commit intoadobe:dev-v2.0.0from
emdobrin:tests
Jan 10, 2023
Merged

Fix network request await for asserts#16
kevinlind merged 1 commit intoadobe:dev-v2.0.0from
emdobrin:tests

Conversation

@emdobrin
Copy link
Copy Markdown
Contributor

@emdobrin emdobrin commented Jan 10, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 10, 2023 •
edited
Loading

Codecov Report

Merging #16 (2ee8e43) into dev-v2.0.0 (d3510d6) will increase coverage by 5.58%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             dev-v2.0.0      #16      +/-   ##
================================================
+ Coverage         76.03%   81.61%   +5.58%     
- Complexity          365      380      +15     
================================================
  Files                29       29              
  Lines              1577     1577              
  Branches            225      225              
================================================
+ Hits               1199     1287      +88     
+ Misses              266      175      -91     
- Partials            112      115       +3
Flag Coverage Δ
functional-tests 66.14% <ø> (?)
unit-tests 76.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...adobe/marketing/mobile/NetworkResponseHandler.java 81.00% <0.00%> (+2.26%) ⬆️
...va/com/adobe/marketing/mobile/ExperienceEvent.java 78.05% <0.00%> (+2.44%) ⬆️
.../marketing/mobile/StoreResponsePayloadManager.java 77.27% <0.00%> (+3.03%) ⬆️
...ain/java/com/adobe/marketing/mobile/EdgeState.java 98.41% <0.00%> (+3.17%) ⬆️
...a/com/adobe/marketing/mobile/EdgeHitProcessor.java 81.82% <0.00%> (+4.55%) ⬆️
...in/java/com/adobe/marketing/mobile/EventUtils.java 87.50% <0.00%> (+6.25%) ⬆️
...java/com/adobe/marketing/mobile/ConsentStatus.java 91.30% <0.00%> (+8.70%) ⬆️
...com/adobe/marketing/mobile/EdgeNetworkService.java 73.40% <0.00%> (+9.04%) ⬆️
...src/main/java/com/adobe/marketing/mobile/Edge.java 48.57% <0.00%> (+21.43%) ⬆️
...java/com/adobe/marketing/mobile/EdgeExtension.java 84.31% <0.00%> (+24.84%) ⬆️

@emdobrin emdobrin marked this pull request as ready for review January 10, 2023 06:12
@emdobrin emdobrin requested a review from kevinlind January 10, 2023 06:12
@kevinlind kevinlind merged commit 192f27a into adobe:dev-v2.0.0 Jan 10, 2023
@emdobrin emdobrin deleted the tests branch January 10, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinlind kevinlind kevinlind approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emdobrin @kevinlind