Skip to content

Updates to CircleCI configuration#1

Merged
emdobrin merged 12 commits intoadobe:devfrom
kevinlind:fix-ci
Nov 16, 2022
Merged

Updates to CircleCI configuration#1
emdobrin merged 12 commits intoadobe:devfrom
kevinlind:fix-ci

Conversation

@kevinlind
Copy link
Copy Markdown
Contributor

@kevinlind kevinlind commented Nov 15, 2022

Description

Updates to CircleCI configuration to get CI builds to pass.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@emdobrin
Copy link
Copy Markdown
Contributor

emdobrin commented Nov 16, 2022

@kevinlind nice, the published artifacts are super helpful 🎉
Do you know if we can filter them out so they only show the main index file for each type of report e.g. public javadocs, coverage, etc and hide the rest?

@kevinlind kevinlind marked this pull request as draft November 16, 2022 04:59
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 16, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (dev@ba1b63e). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev       #1   +/-   ##
======================================
  Coverage       ?   78.25%           
  Complexity     ?      409           
======================================
  Files          ?       31           
  Lines          ?     1770           
  Branches       ?      241           
======================================
  Hits           ?     1385           
  Misses         ?      257           
  Partials       ?      128
Flag Coverage Δ
functional-tests 65.03% <0.00%> (?)
unit-tests 68.19% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@kevinlind
Add codecov.yml configuration
8ce1f2f
@kevinlind
Remove duplcate restore/save gradle cache tasks when running function…
fbc9b95 
…al tests
@kevinlind
Try running CI functional tests with Android 33 x86_64 image
e5b325c
@kevinlind
Use 'system-images;android-29;default;x86' image for functional-tests.
f984b4f 
A recent post by CircleCI suggests that higher API levels and/or system images with Google APIs 'have been observed to be less stable'. It is suggested to use a lower system image if failures are reported.
kevinlind
kevinlind commented Nov 16, 2022
View reviewed changes
.circleci/config.yml
# See options explanation here: https://docs.codecov.com/docs/codecov-uploader
- codecov/upload:
file: ./ci/unit-test/build/reports
file: ci/unit-test/build/reports/jacoco/platformUnitTestJacocoReport/platformUnitTestJacocoReport.xml
Copy link
Copy Markdown
Contributor Author

@kevinlind kevinlind Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file parameter for the CodeCov orb does not recursively search directories, so I'm specifying the exact file to upload.

.circleci/config.yml
executor:
name: android/android-docker
tag: 2022.09.2
tag: 2022.09.2-node
Copy link
Copy Markdown
Contributor Author

@kevinlind kevinlind Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android image requires Node.js because of the build runs Spotless.

.circleci/config.yml
- android/start-emulator-and-run-tests:
# It should match the name seen in the "sdkmanager --list" output
system-image: system-images;android-33;google_apis;x86_64
system-image: system-images;android-29;default;x86
Copy link
Copy Markdown
Contributor Author

@kevinlind kevinlind Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm keeping the same system-image we are using for the other Android Edge extensions. This CircleCI blog post on the Android Emulator states that test issues have been observed with the higher API level images which use Google APIs and it is suggested to use lower API images.

@kevinlind kevinlind marked this pull request as ready for review November 16, 2022 22:55
@kevinlind kevinlind requested a review from emdobrin November 16, 2022 22:56
@emdobrin emdobrin merged commit 7fc0e65 into adobe:dev Nov 16, 2022
@kevinlind kevinlind deleted the fix-ci branch November 16, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emdobrin emdobrin emdobrin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevinlind @emdobrin