Use DataReader for map retrievals #14
Merged
emdobrin merged 5 commits intoadobe:dev-v2.0.0from Dec 22, 2022
Merged
Conversation
kevinlind
reviewed
Dec 22, 2022
Contributor
kevinlind
left a comment
There was a problem hiding this comment.
Left one comment, otherwise looks good.
In RequestBuilder, your use of optTypedMap and then a check for isNullOrEmpty may cause a logged debug message if the typed map exists but is null or empty, which wasn't the case before. I think this change is fine, however, since these maps are not expected to be null/empty.
code/edge/src/main/java/com/adobe/marketing/mobile/RequestBuilder.java
Outdated
Show resolved
Hide resolved
kevinlind
approved these changes
Dec 22, 2022
kevinlind
approved these changes
Dec 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: