Skip to content

Use StringUtils, JSONUtils from Core#21

Merged
kevinlind merged 4 commits intoadobe:dev-v2.0.0from
emdobrin:utils-cleanup
Jan 11, 2023
Merged

Use StringUtils, JSONUtils from Core#21
kevinlind merged 4 commits intoadobe:dev-v2.0.0from
emdobrin:utils-cleanup

Conversation

@emdobrin
Copy link
Copy Markdown
Contributor

@emdobrin emdobrin commented Jan 11, 2023

Description

This PR includes clean up on the Utils class maintained by the Edge extension. Started using some of the Utils available in Core 2.x and kept some others for convenience. Increased code coverage for this class.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@emdobrin emdobrin requested a review from kevinlind January 11, 2023 02:36
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 11, 2023 •
edited
Loading

Codecov Report

Merging #21 (f346d04) into dev-v2.0.0 (192f27a) will increase coverage by 6.15%.
The diff coverage is 68.29%.

@@               Coverage Diff                @@
##             dev-v2.0.0      #21      +/-   ##
================================================
+ Coverage         76.03%   82.18%   +6.15%     
- Complexity          365      374       +9     
================================================
  Files                29       29              
  Lines              1577     1543      -34     
  Branches            225      219       -6     
================================================
+ Hits               1199     1268      +69     
+ Misses              266      170      -96     
+ Partials            112      105       -7
Flag Coverage Δ
functional-tests 65.98% <34.15%> (?)
unit-tests 76.47% <68.29%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/com/adobe/marketing/mobile/StateMetadata.java 69.57% <20.00%> (-14.65%) ⬇️
...ava/com/adobe/marketing/mobile/RequestBuilder.java 84.00% <33.33%> (-0.69%) ⬇️
...e/marketing/mobile/CompletionCallbacksManager.java 96.43% <66.67%> (ø)
...adobe/marketing/mobile/NetworkResponseHandler.java 80.36% <66.67%> (+1.62%) ⬆️
...rc/main/java/com/adobe/marketing/mobile/Utils.java 95.24% <83.33%> (+23.47%) ⬆️
...ava/com/adobe/marketing/mobile/EdgeDataEntity.java 86.05% <100.00%> (ø)
...va/com/adobe/marketing/mobile/EdgeEventHandle.java 84.21% <100.00%> (ø)
...com/adobe/marketing/mobile/EdgeNetworkService.java 73.40% <100.00%> (+9.04%) ⬆️
...va/com/adobe/marketing/mobile/ExperienceEvent.java 78.05% <100.00%> (+2.44%) ⬆️
... and 10 more

@emdobrin emdobrin linked an issue Jan 11, 2023 that may be closed by this pull request
Increase code coverage #22
Closed
kevinlind
kevinlind approved these changes Jan 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kevinlind kevinlind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small comment on why not use the StringUtils.isNullOrEmpty in RequestBuilder.

@kevinlind kevinlind merged commit 66bf848 into adobe:dev-v2.0.0 Jan 11, 2023
@emdobrin emdobrin deleted the utils-cleanup branch January 11, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinlind kevinlind kevinlind approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Increase code coverage

2 participants

@emdobrin @kevinlind