Bump pdfjs-dist from 2.0.161 to 4.6.82 by dependabot[bot] · Pull Request #1098 · UniversalViewer/universalviewer

dependabot · 2024-09-02T00:13:18Z

Bumps pdfjs-dist from 2.0.161 to 4.6.82.

Release notes

v4.6.82

This release contains improvements for the annotation editor, font rendering, form rendering, performance, text selection and the viewer.

Changes since v4.5.136

Bump the stable version in pdfjs.config by @timvandermeij in mozilla/pdf.js#18500

Shorten the errors mentioning API parameters in BaseCMapReaderFactory and BaseStandardFontDataFactory by @Snuffleupagus in mozilla/pdf.js#18502

Initialize all user-options upfront in AppOptions by @Snuffleupagus in mozilla/pdf.js#18501

Disable link annotations during text selection by @nicolo-ribaudo in mozilla/pdf.js#18481

Ignore non-dictionary nodes when parsing StructTree data (issue 18503) by @Snuffleupagus in mozilla/pdf.js#18504

Stop testing in Node.js 21 since it's reached end-of-life by @Snuffleupagus in mozilla/pdf.js#18505

Update dependencies to the most recent versions by @timvandermeij in mozilla/pdf.js#18506

Remove PDFWorkerUtil and move its contents into PDFWorker instead by @Snuffleupagus in mozilla/pdf.js#18507

Remove the globals dependency by @timvandermeij in mozilla/pdf.js#18509

Improve how the findbar's toggle button is referenced in the viewer code by @timvandermeij in mozilla/pdf.js#18510

[Editor] Implement the new alt text flow (bug 1909604) by @calixteman in mozilla/pdf.js#18492

[Editor] Add a checkerboard behind the image preview in the new alt-text dialog in order to see its potential transparency by @calixteman in mozilla/pdf.js#18516

[Editor] Allow Float32Array for quadpoints in annotations (bug 1907958) by @calixteman in mozilla/pdf.js#18526

Give all HTML button elements a type by @timvandermeij in mozilla/pdf.js#18517

Introduce a CSS variable for the toolbar height (bug 1171799) by @timvandermeij in mozilla/pdf.js#18518

Further emphasize the importance of Attach (recommended) or Link to PDF file in the bug report template by @Snuffleupagus in mozilla/pdf.js#18535

Move all event listeners into Toolbar.prototype.#bindListeners by @Snuffleupagus in mozilla/pdf.js#18523

[Editor] Add a new dialog for alt-text settings (bug 1909604) by @calixteman in mozilla/pdf.js#18537

[Editor] Use the color defined for the message bar foreground by @calixteman in mozilla/pdf.js#18539

[Editor] Fix l10n issues by @calixteman in mozilla/pdf.js#18538

[Editor] Don't create the image settings dialog if new alt-text is disabled by @calixteman in mozilla/pdf.js#18540

[Editor] Avoid to have the create alt-text button without a click listener by @calixteman in mozilla/pdf.js#18543

Fix the color of the buttons in a dialog in HCM by @calixteman in mozilla/pdf.js#18547

Link to the list of supported browsers in the bug report template by @Snuffleupagus in mozilla/pdf.js#18542

Inline single-line event handlers in the web/app.js file by @Snuffleupagus in mozilla/pdf.js#18527

[Editor] Load the model when the user switch to the stamp editing mode by @calixteman in mozilla/pdf.js#18546

Improve the larger event listeners in the web/app.js file by @Snuffleupagus in mozilla/pdf.js#18544

[Editor] Guess alt text even when showing the dialog is disabled by @calixteman in mozilla/pdf.js#18541

Stop sending the unused options parameter to various download-methods in the viewer by @Snuffleupagus in mozilla/pdf.js#18551

Empty fields are 0 when using AFSimple_Calculate by @calixteman in mozilla/pdf.js#18552

Update the Babel plugin to remove empty static blocks by @nicolo-ribaudo in mozilla/pdf.js#18562

Update dependencies to the most recent versions by @timvandermeij in mozilla/pdf.js#18554

Use the waitForEvent helper function in the text layer integration tests by @timvandermeij in mozilla/pdf.js#18555

Define a few editor event handler functions inline by @Snuffleupagus in mozilla/pdf.js#18560

[Editor] Update the disclaimer string in the new alt-text dialog (bug 1911738) by @calixteman in mozilla/pdf.js#18570

Remove obsolete otherPages variable from the scripting integration tests by @timvandermeij in mozilla/pdf.js#18567

Don't stop calculating field values when a Calculate callback throws by @calixteman in mozilla/pdf.js#18566

[Editor] Add the uiManager to the window object when testing by @calixteman in mozilla/pdf.js#18574

[Editor] Move the AI icon on the top of its parent div by @calixteman in mozilla/pdf.js#18575

[Editor] Dispatch changes in prefs enableAltTextModelDownload and enableGuessAltText to the viewer (bug 1912024) by @calixteman in mozilla/pdf.js#18573

Revert "[Editor] Dispatch changes in prefs enableAltTextModelDownload and enableGuessAltText to the viewer (bug 1912024)" by @calixteman in mozilla/pdf.js#18578

Dispatch changes in prefs enableAltTextModelDownload and enableGuessAltText to the viewer (bug 1912024) by @calixteman in mozilla/pdf.js#18579

[Editor] Pass a buffer instead of a typed array when passing image data to the model by @calixteman in mozilla/pdf.js#18580

Enable the unicorn/{prefer-includes,throw-new-error} linting rules by @timvandermeij in mozilla/pdf.js#18571

Remove the eslint-plugin-mozilla dependency by @timvandermeij in mozilla/pdf.js#18583

Group and scope the findbar rules using CSS nesting by @timvandermeij in mozilla/pdf.js#18568

... (truncated)

Commits

See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [pdfjs-dist](https://github.com/mozilla/pdf.js) from 2.0.161 to 4.6.82. - [Release notes](https://github.com/mozilla/pdf.js/releases) - [Commits](https://github.com/mozilla/pdf.js/commits/v4.6.82) --- updated-dependencies: - dependency-name: pdfjs-dist dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

vercel · 2024-09-02T00:13:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
universalviewer	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 2, 2024 0:16am

demiankatz · 2024-09-02T13:47:08Z

@Saira-A, I think it's potentially misleading to merge this PR -- I think we should probably make some further revisions on top of what was done here.

When UV was converted to use WebPack, @edsilv was unable to get PDF.js to work in a WebPack build, and since that time, the PDF.js included via NPM has not been used. Instead, the library is loaded from a CDN through a hard-coded URL here:

universalviewer/src/content-handlers/iiif/modules/uv-pdfcenterpanel-module/PDFCenterPanel.ts

Lines 283 to 295 in e52fe6b

    
           // use pdfjs cdn, it just isn't working with webpack 
        
           if (!this._pdfjsLib) { 
        
             await loadScripts([ 
        
               "//cdnjs.cloudflare.com/ajax/libs/pdf.js/3.11.174/pdf.min.js", 
        
             ]); 
        
             this._pdfjsLib = window["pdfjs-dist/build/pdf"]; 
        
             this._pdfjsLib.GlobalWorkerOptions.workerSrc = 
        
               "//cdnjs.cloudflare.com/ajax/libs/pdf.js/3.11.174/pdf.worker.min.js"; 
        
           } else { 
        
             this._$progress[0].setAttribute("value", "0"); 
        
             this._$progress.show(); 
        
             this._$canvas.hide(); 
        
           }

As you can see, that's currently using v3.11.174, which doesn't match either of the versions mentioned by this PR.

I think there are a few things we could possibly do:

1.) Figure out a way to solve the Webpack problem, so UV actually uses the PDF.js version advertised in package.json. This would obviously be the ideal solution, but I don't have the expertise necessary to tackle it. My library doesn't even use PDF.js (we prefer PDFObject, because we've found PDF.js to be unstable for many of the PDFs in our collection), so I can't really justify investing time and effort into learning how to fix it.

2.) We could remove pdf.js from package.json entirely. This might be the most honest solution, but it also kind of masks that a potential problem exists.

3.) We could synchronize the versions between package.json and the hard-coded CDN URL so we're at least reporting the right version. My understanding is that the PDF.js integration is somewhat fragile, so I'm not sure whether upgrading from major version 3 to major version 4 will even work -- but it could be tried, and if it fails, we could roll back the number in package.json.

What do you think?

Saira-A · 2024-09-02T14:03:29Z

I agree that the first option sounds the best, but I don't know if were were using PDF.js either. I'll revert this back to how it was for now

demiankatz · 2024-09-02T14:11:14Z

Thanks, @Saira-A. Does your collection include PDFs? If so, you are probably using PDF.js unless you have specifically switched it off through configuration.

dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Sep 2, 2024

dependabot Bot mentioned this pull request Sep 2, 2024

Bump pdfjs-dist from 2.0.161 to 4.5.136 #1064

Closed

vercel Bot deployed to Preview – universalviewer September 2, 2024 00:14 View deployment

Saira-A merged commit c4dcbf7 into dev Sep 2, 2024

dependabot Bot deleted the dependabot/npm_and_yarn/dev/pdfjs-dist-4.6.82 branch September 2, 2024 12:00

Saira-A mentioned this pull request Sep 2, 2024

Adjust pdfjs-dist to reflect actual version being used via CDN. #1099

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Bump pdfjs-dist from 2.0.161 to 4.6.82#1098

Bump pdfjs-dist from 2.0.161 to 4.6.82#1098
Saira-A merged 1 commit into
devfrom
dependabot/npm_and_yarn/dev/pdfjs-dist-4.6.82

dependabot Bot commented on behalf of github Sep 2, 2024

Uh oh!

vercel Bot commented Sep 2, 2024 •

edited

Loading

Uh oh!

demiankatz commented Sep 2, 2024

Uh oh!

Saira-A commented Sep 2, 2024

Uh oh!

demiankatz commented Sep 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

dependabot Bot commented on behalf of github Sep 2, 2024

v4.6.82

Changes since v4.5.136

Uh oh!

vercel Bot commented Sep 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

demiankatz commented Sep 2, 2024

Uh oh!

Saira-A commented Sep 2, 2024

Uh oh!

demiankatz commented Sep 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented Sep 2, 2024 •

edited

Loading