Skip to content

Don't stop calculating field values when a Calculate callback throws#18566

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:issue18561
Aug 6, 2024
Merged

Don't stop calculating field values when a Calculate callback throws#18566
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:issue18561

Conversation

@calixteman

@calixteman calixteman commented Aug 5, 2024

Copy link
Copy Markdown
Contributor

It fixes #18561.

@calixteman

calixteman commented Aug 5, 2024

Copy link
Copy Markdown
Contributor Author

/botio integrationtest

@moz-tools-bot

moz-tools-bot commented Aug 5, 2024

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d5aeb994707e414/output.txt

@moz-tools-bot

moz-tools-bot commented Aug 5, 2024

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/840e340dca6454a/output.txt

@moz-tools-bot

moz-tools-bot commented Aug 5, 2024

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d5aeb994707e414/output.txt

Total script time: 8.76 mins

  • Integration Tests: Passed

timvandermeij
timvandermeij reviewed Aug 5, 2024
View reviewed changes
Comment thread test/integration/scripting_spec.mjs Outdated
Comment thread test/integration/scripting_spec.mjs Outdated
@moz-tools-bot

moz-tools-bot commented Aug 5, 2024

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/840e340dca6454a/output.txt

Total script time: 18.24 mins

  • Integration Tests: Passed

timvandermeij
timvandermeij reviewed Aug 5, 2024
View reviewed changes
Comment thread test/integration/scripting_spec.mjs Outdated
@calixteman

calixteman commented Aug 5, 2024

Copy link
Copy Markdown
Contributor Author

/botio integrationtest

@moz-tools-bot

moz-tools-bot commented Aug 5, 2024

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/942e74ecdb79d3f/output.txt

@moz-tools-bot

moz-tools-bot commented Aug 5, 2024

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/55b4d4bf3439cbf/output.txt

@moz-tools-bot

moz-tools-bot commented Aug 5, 2024

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/942e74ecdb79d3f/output.txt

Total script time: 8.55 mins

  • Integration Tests: Passed

@moz-tools-bot

moz-tools-bot commented Aug 5, 2024

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/55b4d4bf3439cbf/output.txt

Total script time: 19.92 mins

  • Integration Tests: FAILED

@timvandermeij

timvandermeij commented Aug 6, 2024

Copy link
Copy Markdown
Collaborator

/botio-linux preview

@moz-tools-bot

moz-tools-bot commented Aug 6, 2024

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8885b60f6b39299/output.txt

@moz-tools-bot

moz-tools-bot commented Aug 6, 2024

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/8885b60f6b39299/output.txt

Total script time: 1.90 mins

Published

@timvandermeij timvandermeij merged commit 341a0b6 into mozilla:master Aug 6, 2024
@timvandermeij

timvandermeij commented Aug 6, 2024

Copy link
Copy Markdown
Collaborator

Thank you for improving this!

@YuvrajKaushal YuvrajKaushal mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees

No one assigned

Labels

form-js

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: PDF.js not Performing Calculations on Interactive PDF Forms

3 participants

@calixteman @moz-tools-bot @timvandermeij