Skip to content

[Editor] Guess alt text even when showing the dialog is disabled#18541

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:use_ml_but_no_dialog
Aug 2, 2024
Merged

[Editor] Guess alt text even when showing the dialog is disabled#18541
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:use_ml_but_no_dialog

Conversation

@calixteman

@calixteman calixteman commented Aug 2, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@calixteman

calixteman commented Aug 2, 2024

Copy link
Copy Markdown
Contributor Author

/botio integrationtest

@moz-tools-bot

moz-tools-bot commented Aug 2, 2024

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e2fa11f0e1f1cf3/output.txt

@moz-tools-bot

moz-tools-bot commented Aug 2, 2024

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7bf896c0142b86d/output.txt

@moz-tools-bot

moz-tools-bot commented Aug 2, 2024

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/7bf896c0142b86d/output.txt

Total script time: 8.42 mins

  • Integration Tests: Passed

@moz-tools-bot

moz-tools-bot commented Aug 2, 2024

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/e2fa11f0e1f1cf3/output.txt

Total script time: 17.24 mins

  • Integration Tests: FAILED

@calixteman calixteman requested review from Snuffleupagus and timvandermeij and removed request for Snuffleupagus August 2, 2024 13:58
Snuffleupagus
Snuffleupagus reviewed Aug 2, 2024
View reviewed changes
Comment thread src/display/editor/stamp.js Outdated
@calixteman calixteman force-pushed the use_ml_but_no_dialog branch from 9a4b7fc to 1ca0ad3 Compare August 2, 2024 15:04
Snuffleupagus
Snuffleupagus approved these changes Aug 2, 2024
View reviewed changes

@Snuffleupagus Snuffleupagus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the inline question answered; thank you.

Comment thread web/new_alt_text_manager.js
@calixteman calixteman force-pushed the use_ml_but_no_dialog branch from 1ca0ad3 to d2c519e Compare August 2, 2024 15:40
@calixteman

calixteman commented Aug 2, 2024

Copy link
Copy Markdown
Contributor Author

/botio integrationtest

@moz-tools-bot

moz-tools-bot commented Aug 2, 2024

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/389caf57df818d3/output.txt

@moz-tools-bot

moz-tools-bot commented Aug 2, 2024

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/796edfa39c7b8d8/output.txt

@moz-tools-bot

moz-tools-bot commented Aug 2, 2024

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/389caf57df818d3/output.txt

Total script time: 8.45 mins

  • Integration Tests: Passed

@moz-tools-bot

moz-tools-bot commented Aug 2, 2024

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/796edfa39c7b8d8/output.txt

Total script time: 17.73 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit a372bf8 into mozilla:master Aug 2, 2024
@calixteman calixteman deleted the use_ml_but_no_dialog branch August 2, 2024 16:02
@timvandermeij timvandermeij removed their request for review August 4, 2024 11:25
@YuvrajKaushal YuvrajKaushal mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees

No one assigned

Labels

editor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calixteman @moz-tools-bot @Snuffleupagus