Skip to content

Move all event listeners into Toolbar.prototype.#bindListeners#18523

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:Toolbar-more-bindListeners
Aug 1, 2024
Merged

Move all event listeners into Toolbar.prototype.#bindListeners#18523
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:Toolbar-more-bindListeners

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

Over time a couple of event listeners have been placed in the constructor, despite there being an existing helper method for that purpose. To improve the code organization, let's move these to the intended method instead.

Over time a couple of event listeners have been placed in the constructor, despite there being an existing helper method for that purpose. To improve the code organization, let's move these to the intended method instead.
@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

/botio integrationtest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/23c9934ec7b9fc5/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6934e3bc6905d56/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/23c9934ec7b9fc5/output.txt

Total script time: 8.47 mins

  • Integration Tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/6934e3bc6905d56/output.txt

Total script time: 17.73 mins

  • Integration Tests: FAILED

@timvandermeij

Copy link
Copy Markdown
Collaborator

/botio-linux preview

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c8abaa1310fc0d7/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/c8abaa1310fc0d7/output.txt

Total script time: 1.05 mins

Published

@timvandermeij timvandermeij merged commit d562e05 into mozilla:master Aug 1, 2024
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants