Introduce a CSS variable for the toolbar height (bug 1171799)#18518
Conversation
This refactoring lays the foundation for making the toolbar height configurable in Firefox via the `browser.uidensity` preference. For this to work correctly the toolbar height must be defined in a single place that can easily be updated dynamically, hence this patch which moves it to a CSS variable in such a way that the rest of the UI adapts correctly if the value is changed. Co-authored-by: Calixte Denizet <calixte.denizet@gmail.com>
|
Note that this patch deliberately doesn't resize the inner toolbar elements if the toolbar height is changed yet: that'll be part of a next step because it requires more changes. Not only will those be easier to do once this is in place first, but in the preview in #18385 I found that the sidebar didn't resize correctly if the toolbar height was changed, so that's another reason I wanted to keep this step small so it's more manageable and easier to review. This is a screenshot the preview of #18385 when the toolbar height CSS variable is set to 50px (note that the sidebar overlaps the toolbar):
This is a screenshot of this patch when the toolbar height CSS variable is set to 50px (note that there is no overlap):
You can change the toolbar height dynamically now by opening the preview and changing the |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f8b26890517ba2a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f8b26890517ba2a/output.txt Total script time: 1.04 mins Published |
Snuffleupagus
left a comment
There was a problem hiding this comment.
r=me, thank you!
(Splitting that huge PR into more manageable chunks is very helpful, since I don't think that we can really review it otherwise; and as mentioned in #18385 (comment) there seems to be lots of small movement which might be difficult to pin down in a huge patch.)
This refactoring lays the foundation for making the toolbar height configurable in Firefox via the
browser.uidensitypreference. For this to work correctly the toolbar height must be defined in a single place that can easily be updated dynamically, hence this patch which moves it to a CSS variable in such a way that the rest of the UI adapts correctly if the value is changed.Extracts a part of #18385.