Define a few editor event handler functions inline#18560
Merged
timvandermeij merged 1 commit intoAug 5, 2024
Conversation
Given that we're removing event listeners with `AbortSignal` it's no longer necessary to keep a reference to a few of the event handler functions in order to remove them. Hence we can simply inline the relevant `bind`-calls instead, which reduces the code-size a tiny bit.
Collaborator
Author
|
/botio integrationtest |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d2f90d9efb6adfa/output.txt |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/acbaa6cd4f3ef17/output.txt |
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/acbaa6cd4f3ef17/output.txt Total script time: 8.51 mins
|
Collaborator
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/d2f90d9efb6adfa/output.txt Total script time: 18.09 mins
|
timvandermeij
approved these changes
Aug 5, 2024
Collaborator
|
Thank you for improving this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that we're removing event listeners with
AbortSignalit's no longer necessary to keep a reference to a few of the event handler functions in order to remove them.Hence we can simply inline the relevant
bind-calls instead, which reduces the code-size a tiny bit.